-
Notifications
You must be signed in to change notification settings - Fork 14
fix(deps): resolve HIGH & CRITICAL Dependabot alerts #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release Go toolchain version mismatch
Medium Severity
The
godirective is now1.25, required bykin-openapiv0.144.0, but the publish action still pinsgoreleaser-crossto a Go 1.24.2 image. Release builds therefore run in an older toolchain thango.modrequires, so publishing can fail or depend on an untested automatic toolchain download during CGO cross-compilation.Reviewed by Cursor Bugbot for commit 3b728c1. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid concern. The
godirective moved to1.25as a transitive requirement ofkin-openapi@v0.144.0, while the release path (.github/actions/publish/action.yml) pinsghcr.io/launchdarkly/goreleaser-crossby digest. I can't verify the Go version baked into that pinned image (ghcr requires auth), so I can't confirm whether it's < 1.25.If the image ships Go < 1.25,
goreleaser releasewould rely onGOTOOLCHAIN=autodownloading 1.25 inside the CGO cross-compile container at release time — untested here. This is release infrastructure and the right fix (bump the goreleaser-cross image digest to a Go 1.25 build vs. explicitly relying on toolchain download) depends on maintainer preference, so flagging rather than changing it unilaterally — especially since this PR is already merged. A follow-up PR bumping the goreleaser-cross image to a Go ≥ 1.25 tag is the likely fix.