fix(deps): resolve HIGH & CRITICAL Dependabot alerts - #777
Conversation
Bump direct deps react-router 7.12.0->7.18.2, lodash ->4.18.1, vite ->6.4.3 and transitive deps (rollup, ws, postcss, js-yaml, minimatch, brace-expansion, flatted, form-data, @remix-run/router, react-router-dom via overrides).
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 3b728c1. Configure here.
| module github.com/launchdarkly/ldcli | ||
|
|
||
| go 1.24.3 | ||
| go 1.25 |
There was a problem hiding this comment.
Release Go toolchain version mismatch
Medium Severity
The go directive is now 1.25, required by kin-openapi v0.144.0, but the publish action still pins goreleaser-cross to a Go 1.24.2 image. Release builds therefore run in an older toolchain than go.mod requires, so publishing can fail or depend on an untested automatic toolchain download during CGO cross-compilation.
Reviewed by Cursor Bugbot for commit 3b728c1. Configure here.
There was a problem hiding this comment.
Valid concern. The go directive moved to 1.25 as a transitive requirement of kin-openapi@v0.144.0, while the release path (.github/actions/publish/action.yml) pins ghcr.io/launchdarkly/goreleaser-cross by digest. I can't verify the Go version baked into that pinned image (ghcr requires auth), so I can't confirm whether it's < 1.25.
If the image ships Go < 1.25, goreleaser release would rely on GOTOOLCHAIN=auto downloading 1.25 inside the CGO cross-compile container at release time — untested here. This is release infrastructure and the right fix (bump the goreleaser-cross image digest to a Go 1.25 build vs. explicitly relying on toolchain download) depends on maintainer preference, so flagging rather than changing it unilaterally — especially since this PR is already merged. A follow-up PR bumping the goreleaser-cross image to a Go ≥ 1.25 tag is the likely fix.


Requirements
Related issues
Resolves the open HIGH and CRITICAL Dependabot alerts for this repo.
Describe the solution you've provided
Dependency-only bumps to the minimum patched versions. Scoped to the two manifests with alerts:
go.modandinternal/dev_server/ui/package-lock.json.Go (
go.mod)go get github.com/getkin/kin-openapi@v0.144.0 && go mod tidy(this transitively bumped thegodirective to 1.25, required by kin-openapi 0.144.0).Dev-server UI (
internal/dev_server/ui)Direct deps (
package.json):Transitive deps (lockfile via
npm update):Transitive deps pulled by
@launchpad-ui/components/@launchpad-ui/navigationviareact-router-domv6 (bumped with scopedoverridesinpackage.jsonto keep@launchpad-uion v6 rather than a breaking major upgrade):dist/index.htmlwas regenerated vianpm run build(checked into the repo).Not fixed
None of the open HIGH/CRITICAL alerts were skipped. All 21 open HIGH/CRITICAL alerts (1 CRITICAL Go + 20 HIGH npm) are addressed. Remaining
npm auditfindings are MODERATE/LOW only and out of scope. The@launchpad-ui/*v6react-router/react-router-domMODERATE alerts were intentionally kept on v6 (the only "fix" npm offers is a breaking@launchpad-ui/componentsmajor bump); the HIGH one in that subtree (@remix-run/router#42) is fixed via override.How verified
go build ./...— passesgo test ./...— passes (pre-existing unrelatedcmd/whoamifailure exists onmaintoo)npm test,npm run lint,npm run build— all passnpm audit— 0 high, 0 critical remainingAdditional context
Dependency lockfile churn is limited to the vulnerable packages and their required transitives (incl. rollup platform binaries); no unrelated
@launchpad-ui/react-aria upgrades.Link to Devin session: https://app.devin.ai/sessions/6883fd54fb31445bb549a31426ce6893
Requested by: @pkaeding