Skip to content

registry: add svgo (npm:svgo)#8817

Merged
jdx merged 1 commit intojdx:mainfrom
3w36zj6:feature/add-svgo-to-registry
Mar 30, 2026
Merged

registry: add svgo (npm:svgo)#8817
jdx merged 1 commit intojdx:mainfrom
3w36zj6:feature/add-svgo-to-registry

Conversation

@3w36zj6
Copy link
Copy Markdown
Contributor

@3w36zj6 3w36zj6 commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the svgo tool to the registry, defining its npm backend, description, and a version check test. The feedback suggests adding a detect field with common configuration filenames to enable automatic tool detection by mise.

@@ -0,0 +1,3 @@
backends = ["npm:svgo"]
description = "command-line application for optimizing vector images"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve the user experience, it's beneficial to add a detect field. This allows mise to automatically suggest installing svgo when it detects its configuration file in a project.

Based on svgo's documentation, it supports several configuration file names.

Suggested change
description = "command-line application for optimizing vector images"
description = "command-line application for optimizing vector images"
detect = ["svgo.config.js", "svgo.config.mjs", "svgo.config.cjs", ".svgo.yml", ".svgo.yaml"]

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 29, 2026

Greptile Summary

This PR adds svgo (SVG Optimizer) to the mise tool registry, wiring it to the npm:svgo backend. The addition follows the established registry convention for npm-backed tools and fits cleanly alongside other npm entries such as bibtex-tidy and amp.

  • backends = [\"npm:svgo\"] correctly points to the svgo npm package.
  • description accurately describes the tool as a command-line application for optimizing SVG files.
  • test = { cmd = \"svgo --version\", expected = \"{{version}}\" } is consistent with the actual CLI output: svgo --version prints the bare version string (e.g. 4.0.1) with no prefix, making {{version}} the right matcher.

Confidence Score: 5/5

This PR is safe to merge — it is a minimal, self-contained registry entry with no logic changes.

The single file follows the established registry pattern exactly: correct npm backend identifier, accurate description, and a version test whose expected value ({{version}}) matches the bare version string that svgo --version actually outputs. No issues found.

No files require special attention.

Important Files Changed

Filename Overview
registry/svgo.toml Adds svgo to the mise registry via the npm backend; backend, description, and version test all look correct.

Sequence Diagram

sequenceDiagram
    participant User
    participant mise
    participant Registry as registry/svgo.toml
    participant npm

    User->>mise: mise install svgo
    mise->>Registry: lookup "svgo"
    Registry-->>mise: backends = ["npm:svgo"]
    mise->>npm: npm install -g svgo@<version>
    npm-->>mise: svgo binary installed
    mise->>mise: svgo --version
    mise-->>User: version verified ✓
Loading

Reviews (1): Last reviewed commit: "registry: add svgo (npm:svgo)" | Re-trigger Greptile

@jdx jdx merged commit 89776e3 into jdx:main Mar 30, 2026
33 of 35 checks passed
mise-en-dev added a commit that referenced this pull request Mar 31, 2026
### 🚀 Features

- **(python)** add GitHub provenance verification for prebuilt binaries
by @malept in [#8820](#8820)

### 🐛 Bug Fixes

- **(ci)** use rustls-native-roots for Windows CI build by @jdx in
[#8822](#8822)
- **(go)** improve version fetching logic to support deeply nested
sub-modules by @roele in [#8823](#8823)
- **(shim)** prevent infinite recursion when system shims dir is on PATH
by @andrewthauer in [#8816](#8816)
- go backend missing supports_lockfile_url() override by
@palootcenas-outreach in [#8790](#8790)
- strip shims from PATH in credential and template subprocesses by
@antonioacg in [#8802](#8802)

### 📚 Documentation

- fix typo in shims documentation for fish by @roele in
[#8798](#8798)

### 📦️ Dependency Updates

- update ghcr.io/jdx/mise:alpine docker digest to 3e6d001 by
@renovate[bot] in [#8794](#8794)
- pin dependencies by @renovate[bot] in
[#8793](#8793)

### 📦 Registry

- fix flutter version sorting by @roele in
[#8818](#8818)
- add svgo (npm:svgo) by @3w36zj6 in
[#8817](#8817)

### New Contributors

- @antonioacg made their first contribution in
[#8802](#8802)
- @palootcenas-outreach made their first contribution in
[#8790](#8790)

## 📦 Aqua Registry Updates

#### New Packages (3)

- [`RasKrebs/sonar`](https://github.com/RasKrebs/sonar)
- [`emacs-eask/cli`](https://github.com/emacs-eask/cli)
-
[`superradcompany/microsandbox`](https://github.com/superradcompany/microsandbox)

#### Updated Packages (4)

- [`dimo414/bkt`](https://github.com/dimo414/bkt)
- [`lxc/incus`](https://github.com/lxc/incus)
-
[`shinagawa-web/gomarklint`](https://github.com/shinagawa-web/gomarklint)
- [`updatecli/updatecli`](https://github.com/updatecli/updatecli)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants