Skip to content

docs: fix typo in shims documentation for fish#8798

Merged
jdx merged 1 commit intojdx:mainfrom
roele:issues/shims-typo-fish
Mar 30, 2026
Merged

docs: fix typo in shims documentation for fish#8798
jdx merged 1 commit intojdx:mainfrom
roele:issues/shims-typo-fish

Conversation

@roele
Copy link
Copy Markdown
Contributor

@roele roele commented Mar 27, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 27, 2026 17:37
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 27, 2026

Greptile Summary

This PR fixes a single-line typo in the shims documentation for the fish shell. The second echo command for fish shell setup referenced the wrong filename (fish.config) instead of the correct fish config file (config.fish).

  • Corrects ~/.config/fish/fish.config~/.config/fish/config.fish in the fish shell setup snippet
  • The fix makes both lines in the fish code block consistent, both now correctly appending to ~/.config/fish/config.fish
  • No functional code is affected; this is a documentation-only change

Confidence Score: 5/5

Safe to merge — single-line documentation typo fix with no code changes.

The change is a trivial, obviously correct documentation fix. The fish shell config file is definitively named config.fish (not fish.config), and both lines in the snippet now consistently reference the correct path. No logic, tests, or build artifacts are affected.

No files require special attention.

Important Files Changed

Filename Overview
docs/dev-tools/shims.md Fixes typo: corrects fish shell config file path from ~/.config/fish/fish.config to the correct ~/.config/fish/config.fish

Sequence Diagram

sequenceDiagram
    participant User
    participant Shell as Fish Shell
    participant Config as ~/.config/fish/config.fish

    User->>Config: echo 'mise activate fish --shims | source' (non-interactive setup)
    User->>Config: echo 'mise activate fish | source' (interactive setup)
    Shell->>Config: source on startup
    Config-->>Shell: activates mise (shims mode for non-interactive, full for interactive)
Loading

Reviews (1): Last reviewed commit: "docs: fix typo in shims documentation fo..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a typo in the shims documentation for the Fish shell so users append the activation command to the correct Fish config file.

Changes:

  • Corrects the Fish config file path from ~/.config/fish/fish.config to ~/.config/fish/config.fish in the shims setup instructions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a typo in the fish shell configuration file path within the documentation. Feedback was provided to improve the suggested fish configuration by using a conditional block to handle both interactive and non-interactive sessions correctly, ensuring that the shim setup is not inadvertently overridden.

Comment on lines 95 to +96
echo 'mise activate fish --shims | source' >> ~/.config/fish/config.fish
echo 'mise activate fish | source' >> ~/.config/fish/fish.config
echo 'mise activate fish | source' >> ~/.config/fish/config.fish
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly fixes the typo in the filename, the documented instruction for fish is problematic. Appending both mise activate fish --shims | source and mise activate fish | source to config.fish will result in the second command overriding the first, making the shim setup ineffective for non-interactive shells.

For fish, shell behavior is typically differentiated using if status is-interactive. A better approach is to use a single command that adds a conditional to ~/.config/fish/config.fish to handle both interactive and non-interactive sessions correctly.

Suggested change
echo 'mise activate fish --shims | source' >> ~/.config/fish/config.fish
echo 'mise activate fish | source' >> ~/.config/fish/fish.config
echo 'mise activate fish | source' >> ~/.config/fish/config.fish
echo 'if status is-interactive; mise activate fish | source; else; mise activate fish --shims | source; end' >> ~/.config/fish/config.fish

@jdx jdx merged commit c819ab6 into jdx:main Mar 30, 2026
37 of 40 checks passed
@roele roele deleted the issues/shims-typo-fish branch March 30, 2026 19:55
mise-en-dev added a commit that referenced this pull request Mar 31, 2026
### 🚀 Features

- **(python)** add GitHub provenance verification for prebuilt binaries
by @malept in [#8820](#8820)

### 🐛 Bug Fixes

- **(ci)** use rustls-native-roots for Windows CI build by @jdx in
[#8822](#8822)
- **(go)** improve version fetching logic to support deeply nested
sub-modules by @roele in [#8823](#8823)
- **(shim)** prevent infinite recursion when system shims dir is on PATH
by @andrewthauer in [#8816](#8816)
- go backend missing supports_lockfile_url() override by
@palootcenas-outreach in [#8790](#8790)
- strip shims from PATH in credential and template subprocesses by
@antonioacg in [#8802](#8802)

### 📚 Documentation

- fix typo in shims documentation for fish by @roele in
[#8798](#8798)

### 📦️ Dependency Updates

- update ghcr.io/jdx/mise:alpine docker digest to 3e6d001 by
@renovate[bot] in [#8794](#8794)
- pin dependencies by @renovate[bot] in
[#8793](#8793)

### 📦 Registry

- fix flutter version sorting by @roele in
[#8818](#8818)
- add svgo (npm:svgo) by @3w36zj6 in
[#8817](#8817)

### New Contributors

- @antonioacg made their first contribution in
[#8802](#8802)
- @palootcenas-outreach made their first contribution in
[#8790](#8790)

## 📦 Aqua Registry Updates

#### New Packages (3)

- [`RasKrebs/sonar`](https://github.com/RasKrebs/sonar)
- [`emacs-eask/cli`](https://github.com/emacs-eask/cli)
-
[`superradcompany/microsandbox`](https://github.com/superradcompany/microsandbox)

#### Updated Packages (4)

- [`dimo414/bkt`](https://github.com/dimo414/bkt)
- [`lxc/incus`](https://github.com/lxc/incus)
-
[`shinagawa-web/gomarklint`](https://github.com/shinagawa-web/gomarklint)
- [`updatecli/updatecli`](https://github.com/updatecli/updatecli)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants