docs: fix typo in shims documentation for fish#8798
Conversation
Greptile SummaryThis PR fixes a single-line typo in the shims documentation for the fish shell. The second
Confidence Score: 5/5Safe to merge — single-line documentation typo fix with no code changes. The change is a trivial, obviously correct documentation fix. The fish shell config file is definitively named No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Shell as Fish Shell
participant Config as ~/.config/fish/config.fish
User->>Config: echo 'mise activate fish --shims | source' (non-interactive setup)
User->>Config: echo 'mise activate fish | source' (interactive setup)
Shell->>Config: source on startup
Config-->>Shell: activates mise (shims mode for non-interactive, full for interactive)
Reviews (1): Last reviewed commit: "docs: fix typo in shims documentation fo..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Fixes a typo in the shims documentation for the Fish shell so users append the activation command to the correct Fish config file.
Changes:
- Corrects the Fish config file path from
~/.config/fish/fish.configto~/.config/fish/config.fishin the shims setup instructions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request corrects a typo in the fish shell configuration file path within the documentation. Feedback was provided to improve the suggested fish configuration by using a conditional block to handle both interactive and non-interactive sessions correctly, ensuring that the shim setup is not inadvertently overridden.
| echo 'mise activate fish --shims | source' >> ~/.config/fish/config.fish | ||
| echo 'mise activate fish | source' >> ~/.config/fish/fish.config | ||
| echo 'mise activate fish | source' >> ~/.config/fish/config.fish |
There was a problem hiding this comment.
While this change correctly fixes the typo in the filename, the documented instruction for fish is problematic. Appending both mise activate fish --shims | source and mise activate fish | source to config.fish will result in the second command overriding the first, making the shim setup ineffective for non-interactive shells.
For fish, shell behavior is typically differentiated using if status is-interactive. A better approach is to use a single command that adds a conditional to ~/.config/fish/config.fish to handle both interactive and non-interactive sessions correctly.
| echo 'mise activate fish --shims | source' >> ~/.config/fish/config.fish | |
| echo 'mise activate fish | source' >> ~/.config/fish/fish.config | |
| echo 'mise activate fish | source' >> ~/.config/fish/config.fish | |
| echo 'if status is-interactive; mise activate fish | source; else; mise activate fish --shims | source; end' >> ~/.config/fish/config.fish |
### 🚀 Features - **(python)** add GitHub provenance verification for prebuilt binaries by @malept in [#8820](#8820) ### 🐛 Bug Fixes - **(ci)** use rustls-native-roots for Windows CI build by @jdx in [#8822](#8822) - **(go)** improve version fetching logic to support deeply nested sub-modules by @roele in [#8823](#8823) - **(shim)** prevent infinite recursion when system shims dir is on PATH by @andrewthauer in [#8816](#8816) - go backend missing supports_lockfile_url() override by @palootcenas-outreach in [#8790](#8790) - strip shims from PATH in credential and template subprocesses by @antonioacg in [#8802](#8802) ### 📚 Documentation - fix typo in shims documentation for fish by @roele in [#8798](#8798) ### 📦️ Dependency Updates - update ghcr.io/jdx/mise:alpine docker digest to 3e6d001 by @renovate[bot] in [#8794](#8794) - pin dependencies by @renovate[bot] in [#8793](#8793) ### 📦 Registry - fix flutter version sorting by @roele in [#8818](#8818) - add svgo (npm:svgo) by @3w36zj6 in [#8817](#8817) ### New Contributors - @antonioacg made their first contribution in [#8802](#8802) - @palootcenas-outreach made their first contribution in [#8790](#8790) ## 📦 Aqua Registry Updates #### New Packages (3) - [`RasKrebs/sonar`](https://github.com/RasKrebs/sonar) - [`emacs-eask/cli`](https://github.com/emacs-eask/cli) - [`superradcompany/microsandbox`](https://github.com/superradcompany/microsandbox) #### Updated Packages (4) - [`dimo414/bkt`](https://github.com/dimo414/bkt) - [`lxc/incus`](https://github.com/lxc/incus) - [`shinagawa-web/gomarklint`](https://github.com/shinagawa-web/gomarklint) - [`updatecli/updatecli`](https://github.com/updatecli/updatecli)
No description provided.