"type" is a builtin in python; switch some arguments called "type" to be "type_"#738
"type" is a builtin in python; switch some arguments called "type" to be "type_"#738dan98765 wants to merge 3 commits into
Conversation
8cff4f3 to
b89e2c3
Compare
|
@jkimbo how do you feel about this branch? |
jkimbo
left a comment
There was a problem hiding this comment.
I like it. It's technically a breaking change so lets try and get it in 2.2 with the _resolve_type change as well.
|
@dan98765 needs rebase |
|
Since it’s a breaking change it should probably be part of a 3.0 release (instead of 2.2 as I suggested earlier). Do you agree @graphql-python/governors ? |
|
@jkimbo I'm also using |
mvanlonden
left a comment
There was a problem hiding this comment.
Approving but wait until ready for 3.0 release, should be merged alongside #775
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closes #700
Also:
aniso8601dep to tox.ini to get tests to pass