Skip to content

Rename variables called type to type_#1216

Merged
jkimbo merged 1 commit into
graphql-python:masterfrom
DoctorJohn:rename-vars-shadowing-the-type-inbuilt
Jun 27, 2020
Merged

Rename variables called type to type_#1216
jkimbo merged 1 commit into
graphql-python:masterfrom
DoctorJohn:rename-vars-shadowing-the-type-inbuilt

Conversation

@DoctorJohn
Copy link
Copy Markdown
Contributor

@DoctorJohn DoctorJohn commented Jun 25, 2020

Co-authored-by: Daniel Gallagher daniellg@yelp.com

This is the continuation of #738 . I rebased it on master and replaced type with type_ in some places not covered by the original PR (due to its age).

This PR is related to #1127 and finally fixes #700.

Co-authored-by: Daniel Gallagher <daniellg@yelp.com>
Copy link
Copy Markdown
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkimbo jkimbo merged commit bf034ca into graphql-python:master Jun 27, 2020
DoctorJohn added a commit to DoctorJohn/graphene-pydantic that referenced this pull request Oct 11, 2020
necaris pushed a commit to necaris/graphene-pydantic that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query cannot have a field named 'type'

2 participants