Skip to content

Adding GCCL header for HTTP APIs.#3046

Merged
lukesneeringer merged 4 commits into
googleapis:masterfrom
dhermes:moar-gccl-headers
Feb 22, 2017
Merged

Adding GCCL header for HTTP APIs.#3046
lukesneeringer merged 4 commits into
googleapis:masterfrom
dhermes:moar-gccl-headers

Conversation

@dhermes

@dhermes dhermes commented Feb 21, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Continuation of #3035. Fixes #3006.

For now just a single commit: "Adding __version__ in packages that need HTTP." because I need to step AFK for a bit.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2017
daspecster
daspecster reviewed Feb 21, 2017
View reviewed changes

@daspecster daspecster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick and question. Not trying to block since @lukesneeringer already approved but just some stuff I noticed.

Comment thread monitoring/google/cloud/monitoring/__init__.py

"""Google Stackdriver Monitoring API wrapper."""

from pkg_resources import get_distribution

This comment was marked as spam.

Sign in to view

Comment thread bigquery/google/cloud/bigquery/__init__.py Outdated


from pkg_resources import get_distribution
__version__ = get_distribution('google-cloud-bigquery')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread runtimeconfig/google/cloud/runtimeconfig/__init__.py

"""Google Cloud Runtime Configurator API package."""

from pkg_resources import get_distribution

This comment was marked as spam.

Sign in to view

Comment thread speech/google/cloud/speech/__init__.py
@@ -14,6 +14,9 @@

"""Google Cloud Speech API wrapper."""

This comment was marked as spam.

Sign in to view

Comment thread speech/google/cloud/speech/__init__.py

from pkg_resources import get_distribution
__version__ = get_distribution('google-cloud-speech')

This comment was marked as spam.

Sign in to view

Comment thread translate/google/cloud/translate/__init__.py

"""Google Cloud Translation API wrapper."""

from pkg_resources import get_distribution

This comment was marked as spam.

Sign in to view

Comment thread vision/google/cloud/vision/__init__.py
@@ -14,4 +14,7 @@

"""Google Cloud Vision API package."""

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Feb 22, 2017

Copy link
Copy Markdown
Contributor Author

OK finally got time back at the keyboard.

@lukesneeringer @daspecster PTAL

@lukesneeringer
lukesneeringer merged commit 08785e4 into googleapis:master Feb 22, 2017
@dhermes
dhermes deleted the moar-gccl-headers branch February 22, 2017 16:15
@tseaver tseaver mentioned this pull request Feb 22, 2017
Closed
@daspecster daspecster mentioned this pull request Feb 22, 2017
Closed
3 tasks
@dhermes dhermes mentioned this pull request Feb 24, 2017
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@daspecster daspecster daspecster left review comments
@lukesneeringer lukesneeringer lukesneeringer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes @lukesneeringer @daspecster @tseaver @googlebot