Add more useful header info on HTTP requests #3006

Activity

1. dhermes

   added

   api: core

   hygiene

   on Feb 13, 2017
2. dhermes

   assigned

   tseaver

   and

   dhermes

   on Feb 13, 2017
3. tseaver commented on Feb 13, 2017

   

   tseaver

   on Feb 13, 2017

   Contributor

   More actions

   Seems like we could override the USER_AGENT class attribute for the APIs which use JSONConnection, and derive it from pkg_resources (maybe add a helper for that?). E.g.:

   from pkg_resources import get_distribution
   
   from google.cloud._http import JSONConnection
   
   
   class Connection(JSONConnection):
       USER_AGENT = 'google-cloud-foo-python/{0}'.format(
           get_distribution('google-cloud-foo').version)

   I don't know whether the -python suffix should be there. @lukesneeringer can you confirm?
4. lukesneeringer commented on Feb 13, 2017

   

   lukesneeringer

   on Feb 13, 2017

   Last edited by lukesneeringer

   Contributor

   More actions

   It is actually moving to a new header, X-Goog-API-Client, and the client library is going to be abbreviated gccl (google cloud client library).

   We also intend to track the language via gl-python/{v}, which should appear at the beginning of the string. GAX already does this, but the HTTP base client will need to add it, too.

   We probably still need to set a User-Agent string (just because it is considered good practice), and it does not matter what it is. google-cloud-core/{v} seems appropriate for that but I will defer to whatever you folks want (provided it is sane).
5. dhermes commented on Feb 13, 2017

   

   dhermes

   on Feb 13, 2017

   ContributorAuthor

   More actions

   @lukesneeringer The value of gcloud-python used to be deemed "sacred" to preserve some reporting internal to Google. That may no longer be true.
6. lukesneeringer commented on Feb 13, 2017

   

   lukesneeringer

   on Feb 13, 2017

   Contributor

   More actions

   This is no longer true. The new header is superceding the old one.
7. dhermes

   unassigned

   tseaver

   on Feb 16, 2017
8. dhermes commented on Feb 17, 2017

   

   dhermes

   on Feb 17, 2017

   Last edited by dhermes

   ContributorAuthor

   More actions

   #3035 is most of the "intellectual conceptual way" towards this
9. dhermes commented on Feb 21, 2017

   

   dhermes

   on Feb 21, 2017

   Last edited by dhermes

   ContributorAuthor

   More actions

   Remaining APIs:

   • bigquery
   • datastore
   • dns
   • error_reporting
   • language
   • logging
   • monitoring
   • pubsub
   • resource_manager
   • runtimeconfig
   • speech
   • storage
   • translate
   • vision
10. lukesneeringer

    closed this as completedin #3046on Feb 22, 2017