Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

Fix for #169: unused imports - #254

Merged
software-dov merged 3 commits into
googleapis:masterfrom
software-dov:unused-imports
Dec 10, 2019
Merged

software-dov merged 3 commits into
googleapis:masterfrom
software-dov:unused-imports

Conversation

@software-dov

Copy link
Copy Markdown
Contributor

Fix the unused import of api_core.operation and protobuf.empty_pb2 in
generated unit tests.

The fix is hacky, gross, and specific, but presumably it should generalize.

Fix the unused import of api_core.operation and protobuf.empty_pb2 in
generated unit tests
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2019
@codecov

codecov Bot commented Dec 2, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #254 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #254   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          25     25           
  Lines        1338   1338           
  Branches      278    278           
=====================================
  Hits         1338   1338

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0730c80...b6bc2d8. Read the comment docs.

@software-dov

Copy link
Copy Markdown
Contributor Author

Open review bump

@software-dov
software-dov merged commit 8fd94b2 into googleapis:master Dec 10, 2019
@software-dov
software-dov deleted the unused-imports branch December 10, 2019 00:17
@software-dov software-dov mentioned this pull request Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants