This repository was archived by the owner on Aug 25, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 25, 2026. It is now read-only.
Unused imports #169
Description
Flake raises warnings about unused imports.
See https://github.com/googleapis/google-cloud-python-private/pull/504
google/cloud/workflows_v1alpha1/services/workflows/pagers.py:2:1: F401 'copy' imported but unused
google/cloud/workflows_v1alpha1/services/workflows/client.py:3:1: F401 'typing.Mapping' imported but unused
google/cloud/workflows_v1alpha1/services/workflows/client.py:3:1: F401 'typing.Optional' imported but unused
google/cloud/workflows_v1alpha1/services/workflows/transports/grpc.py:2:1: F401 'typing.Sequence' imported but unused
google/cloud/workflows_v1alpha1/services/workflows/transports/grpc.py:2:1: F401 'typing.Tuple' imported but unused
tests/unit/workflows_v1alpha1/test_workflows.py:10:1: F401 'google.api_core.operation' imported but unused
tests/unit/workflows_v1alpha1/test_workflows.py:18:1: F401 'google.protobuf.empty_pb2 as empty' imported but unused
Activity
lukesneeringer commentedon Aug 12, 2019
I added a PR (#177) for the easy ones. The two in the unit tests are actually somewhat difficult, but still worth trying to bop out.
software-dov commentedon Aug 16, 2019
For the two in
test_workflows.py, I don't see the corresponding imports in thetest_$service.py.j2. Am I misreading the template? Has the issue been fixed and there's now just version shear?lukesneeringer commentedon Aug 20, 2019
It is rendered by the last loop, I believe.
Fix for googleapis#169: unused imports
Fix for #169: unused imports (#254)
software-dov commentedon Dec 10, 2019
Last bit fixed by #254