Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

F401 imported but unused #324

Closed
Closed

Description

@busunkim96

More unused imports (but different from the ones in #169).

If the answer is "It's hard to get rid of these" I can live with that, but I would still like to track this in an issue.

google/cloud/billing_v1/services/cloud_catalog/client.py:19:1: F401 'typing.Iterable' imported but unused
google/cloud/billing_v1/services/cloud_catalog/client.py:19:1: F401 'typing.Iterator' imported but unused
google/cloud/billing_v1/services/cloud_catalog/client.py:23:1: F401 'google.api_core.exceptions' imported but unused
google/cloud/billing_v1/services/cloud_billing/client.py:19:1: F401 'typing.Iterable' imported but unused
google/cloud/billing_v1/services/cloud_billing/client.py:19:1: F401 'typing.Iterator' imported but unused
google/cloud/billing_v1/services/cloud_billing/client.py:23:1: F401 'google.api_core.exceptions' imported but unused
tests/unit/billing_v1/test_cloud_catalog.py:21:1: F401 'math' imported but unused
tests/unit/billing_v1/test_cloud_billing.py:21:1: F401 'math' imported but unused

Activity

  1. software-dov commented on Feb 28, 2020

    @software-dov
    Contributor

    Mostly fixed by #329
    Unused 'math' import is still present in generated tests.
    Unused 'exceptions' import is still present in generated client.

  2. larkee commented on Sep 17, 2020

    @larkee

    For Cloud Spanner, tests/unit/gapic/spanner_v1/test_spanner.py contains the following unused imports:

    from google.cloud.spanner_v1.types import type
    from google.cloud.spanner_v1.types import type as gs_type
    

    The first import is causing test breakages as it clashes with the type() builtin.

  3. software-dov commented on Sep 29, 2020

    @software-dov
    Contributor

    Fixed by #595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions