Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -2133,6 +2133,7 @@ The main entry re-exported the build plugin statically, which pulled the whole b
`any`.
- Attribute typing and serialization were unified across the SDK.
- The `attributes` field on the `ScopeData` type is now required. `Scope.getScopeData()` always returned it, so this only affects code that constructs `ScopeData` objects manually — add `attributes: {}` there.
- The `attributes` field on the `SamplingContext` passed to `tracesSampler` is now required (previously optional); it is always provided by the SDK, so this only affects code that narrows or constructs `SamplingContext` objects by hand.
- The `endTimestamp` property was removed from the `SentrySpanArguments` interface. It was never part of
`StartSpanOptions`, so it could only be passed by ignoring TypeScript, in which case the span ended itself
during construction. Call `span.end(timestamp)` instead.
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/types/samplingcontext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export interface SamplingContext extends CustomSamplingContext {
name: string;

/** Initial attributes that have been passed to the span being sampled. */
attributes?: RawAttributes<Record<string, unknown>>;
attributes: RawAttributes<Record<string, unknown>>;
}

/**
Expand Down
Loading