ref(core)!: Make attributes in sampling context required - #24153
Merged
Conversation
6 tasks
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
September 7, 2026 12:27
JPeer264
approved these changes
Sep 7, 2026
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is technically breaking, I think, but I'm not even sure 🤔 any code that used to work before this should still work I believe. I guess it is only breaking if you add a handler manually that is typed in a way that
attributesare optional, but now they aren't. It is already today always present, so really just a type change to ensure you don't need to guard this all the time in the handler.