Repository navigation
fix(i18n): polish Simplified Chinese tooltips - #1077
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to This change updates Simplified Chinese tooltips and documentation without a described application behavior change, and the checked trim terminology is consistent. No concrete user-facing defect is evident; it is ready for normal merge checks. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title clearly identifies the change as polishing Simplified Chinese tooltips, which matches the primary localization work. |
| Description check | |
The description covers the change, related issues, change type, release and desktop impact, screenshots, and testing. It also states which checks passed and which could not be completed. |
✨ Finishing Touches
-
-
🧪 Generate unit tests (beta)
-
-
- Create a new PR
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔇 Additional comments (6)
src/i18n/locales/zh-CN/editor.json (1)
121-122: LGTM!Also applies to: 162-162, 170-170, 219-219, 221-221, 257-257, 259-259, 279-279, 330-330
src/i18n/locales/zh-CN/launch.json (1)
3-7: LGTM!Also applies to: 10-11, 15-17, 36-36, 57-57, 70-71, 73-73, 94-94
src/i18n/locales/zh-CN/settings.json (1)
123-123: LGTM!Also applies to: 134-134, 179-179, 192-192, 278-278, 318-318, 339-343, 412-414, 435-435
src/i18n/locales/zh-CN/shortcuts.json (1)
20-20: LGTM!src/i18n/locales/zh-CN/timeline.json (1)
3-10: LGTM!Also applies to: 14-14, 25-25, 28-28, 39-40, 61-62, 82-83, 99-99
src/i18n/locales/zh-CN/editor.json-118-118 (1)
118-118: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Use a natural recording phrase.
录入视频is awkward for describing a cursor captured in video. Use直接录制到视频中consistently.
src/i18n/locales/zh-CN/editor.json#L118-L118: Replace录入视频with录制到视频中.src/i18n/locales/zh-CN/launch.json#L58-L58: Replace录入视频with录制到视频中.website/i18n/zh-CN/docusaurus-plugin-content-docs/current/recording.md#L83-L83: Replace录入视频with录制到视频中.
ℹ️ Review info
⚙️ Run configuration
- Configuration used: defaults
- Review profile: CHILL
- Plan: Advanced
- Run ID:
0d19d88a-62a1-46fe-9670-9ca7efcd4985
📒 Files selected for processing (6)
src/i18n/locales/zh-CN/editor.jsonsrc/i18n/locales/zh-CN/launch.jsonsrc/i18n/locales/zh-CN/settings.jsonsrc/i18n/locales/zh-CN/shortcuts.jsonsrc/i18n/locales/zh-CN/timeline.jsonwebsite/i18n/zh-CN/docusaurus-plugin-content-docs/current/recording.md
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
Icon-only rail and timeline buttons are named by their tooltip (Name: effect). Restore the name prefix on the facet, edit-clip, regenerate and Full Camera tips, and use the more natural 录制到视频中 for the system cursor.
The docs name interface elements with the app's own translation: update the trim region term, the hide-recording-bar button and the Linux picker hint.
|
Pushed two small follow-ups: icon-only tooltips (inspector rail, regenerate, Full Camera) keep the control name, since the tooltip is the only visible name there; applied CodeRabbit's 录入视频 → 录制到视频中; synced the zh-CN docs to the renamed labels. Thanks for the careful pass! |
it is all right |
EtienneLescot
left a comment
EtienneLescot
left a comment
There was a problem hiding this comment.
Reviewed: zh-CN values only, keys and placeholders intact; icon-only control names restored in their tooltips. Thanks @auberginewly!
3 participants
Summary
The Simplified Chinese tooltips from #912, #914 and #915 contain literal translations and inconsistent editing terms. Rewrite the affected wording so actions and effects read naturally in Chinese. For example, the recording bar is now “录制栏” rather than “托盘”, and trim regions are “删减区间” rather than the broad “剪辑”.
Keep trim terminology consistent across timeline labels, hints, errors, the inspector and keyboard shortcuts. Preserve “裁剪” for spatial cropping and use “修剪范围” for clip endpoint trimming. Clarify camera-picture behavior, transcript corrections and chat actions, and update the matching Chinese recording documentation.
Maintainer follow-up: icon-only tooltips keep the control name (
Name: effect, pertechnical-documentation/engineering/tooltips.md), and the zh-CN docs now use the renamed app labels (删减区间, 隐藏录制栏, the Linux picker hint).All translation keys and interpolation placeholders are unchanged. Other locales are outside this PR's scope.
Related issue
Refs #913
This addresses the zh-CN portion, including the follow-up review requested for #914 and #915. It does not close the multilingual review issue.
Type of change
Release impact
Desktop impact
Screenshots / video
Copy-only changes. No screenshots are attached; an in-app visual pass has not been run.
Testing
npm run i18n:check: passed for all 15 locales and 924 literal translation calls.vitest run src/i18n/__tests__: 3 files, 121 tests passed, covering locale parity, tooltip placeholders/length and help translations.git diff --check: passed.npm ci --ignore-scripts) was interrupted by a registry connection reset. Application/test typechecks attempted during that incomplete installation could not resolve LangChain declarations; they are not claimed as passing. Full application tests/build and desktop visual checks were not run.Local checks currently use Node 22.23.3 and npm 10.9.4; the repository pins Node 22.22.1.
AI assistance was used for drafting, checking the wording against the English strings and preparing this contribution, including the Humanizer skill. This does not claim an independent native-speaker sign-off or an in-app end-to-end pass.
Summary by CodeRabbit