Closed
Conversation
The github library needs a weird linking trick: it needs to have `github.unix` specified before `github` -- as some tools can reorder the findlinb deps, be sure that `github` has a `github.unix` on both sides ...
Collaborator
Author
|
/cc @dsheets ideally this should be solved in |
Owner
|
That's very strange. What's the error? |
Collaborator
Author
|
That the same as #7. Seems that The exact error is without that patch (using jbuilder) is: |
Owner
|
Does putting |
Owner
|
This sounds like a jbuilder bug... the closure of deps isn't being spliced in to the package link list in the right place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The github library needs a weird linking trick: it needs to have
github.unixspecified before
github-- as some tools can reorder the findlinb deps, besure that
githubhas agithub.unixon both sides ...