Skip to content

Fix META file#7

Merged
samoht merged 1 commit intodsheets:masterfrom
samoht:master
Oct 6, 2016
Merged

Fix META file#7
samoht merged 1 commit intodsheets:masterfrom
samoht:master

Conversation

@samoht
Copy link
Copy Markdown
Collaborator

@samoht samoht commented Oct 6, 2016

Note: it seems that the order of elements matters here. /cc @dbuenzli

Note: it seems that the order of elements matters here.
@samoht samoht merged commit 498e3ff into dsheets:master Oct 6, 2016
@dsheets
Copy link
Copy Markdown
Owner

dsheets commented Oct 6, 2016

Matters how? The previous content built fine for me with ocamlfind 1.6.2.

@samoht
Copy link
Copy Markdown
Collaborator Author

samoht commented Oct 6, 2016

It builds fine, but when you #require "github-hooks.unix in a toplevel you have a problem if the META file doesn't list the packages in the right order.

@dbuenzli
Copy link
Copy Markdown

dbuenzli commented Oct 7, 2016

What kind of problem ?

@samoht
Copy link
Copy Markdown
Collaborator Author

samoht commented Oct 10, 2016

The github package has 2 implementation github.unix and github.jsoo. github-hooks depends on github, but github-hooks.unix depends on github.unix. So github-hooks-unix has to lad github.unix before trying to load github-hooks.

@samoht samoht mentioned this pull request Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants