Skip to content

Remove some more no-restricted-imports lint disabling comments from wrangler#13255

Open
dario-piotrowicz wants to merge 1 commit intomainfrom
dario/some-more-no-restricted-imports
Open

Remove some more no-restricted-imports lint disabling comments from wrangler#13255
dario-piotrowicz wants to merge 1 commit intomainfrom
dario/some-more-no-restricted-imports

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Apr 2, 2026

Removal of a bunch of comments like:

// eslint-disable-next-line no-restricted-imports

from the wrangler

Continuation from #13140, #13149 #13164, #13247 and #13245


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactoring

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 2, 2026

⚠️ No Changeset found

Latest commit: b87f637

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 2, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13255

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13255

miniflare

npm i https://pkg.pr.new/miniflare@13255

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13255

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13255

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13255

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13255

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13255

wrangler

npm i https://pkg.pr.new/wrangler@13255

commit: b87f637

@ask-bonk

This comment was marked as outdated.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/some-more-no-restricted-imports branch from 45323ed to d8a1370 Compare April 2, 2026 22:17
@dario-piotrowicz dario-piotrowicz force-pushed the dario/some-more-no-restricted-imports branch from d8a1370 to b87f637 Compare April 2, 2026 23:03
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review April 2, 2026 23:29
@workers-devprod workers-devprod requested review from a team and NuroDev and removed request for a team April 2, 2026 23:30
@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/d1
  • @cloudflare/workers-kv
  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/wrangler/src/tests/autoconfig/run.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/cloudchamber/apply.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/cloudchamber/create.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/cloudchamber/modify.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/containers/delete.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/containers/deploy.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/containers/registries.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/d1/delete.test.ts: [@cloudflare/d1 @cloudflare/wrangler]
  • packages/wrangler/src/tests/delete.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/deploy/entry-points.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/deploy/workflows.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/dev.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/kv/bulk.test.ts: [@cloudflare/workers-kv @cloudflare/wrangler]
  • packages/wrangler/src/tests/kv/key.test.ts: [@cloudflare/workers-kv @cloudflare/wrangler]
  • packages/wrangler/src/tests/kv/namespace.test.ts: [@cloudflare/workers-kv @cloudflare/wrangler]
  • packages/wrangler/src/tests/metrics.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/pages/deployment-list.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/pages/pages-download-config.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/pages/project-list.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/pages/secret.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/pipelines-setup.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/pipelines.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/provision.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/queues/queues.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/rollback.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/secret.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/tail.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/utils/log-file.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/secrets/bulk.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/secrets/delete.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/secrets/list.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/secrets/put.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/secrets/utils.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/workflows.test.ts: [@cloudflare/wrangler]

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants