Remove all removable eslint comments disabling no-restricted-imports from c3

[dario-piotrowicz]

Removal of comments such as:

// eslint-disable-next-line no-restricted-imports

In the create-cloudflare package

Continuation from #13140, #13149 and #13164

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: internal refactoring

A picture of a cute animal (not mandatory, but encouraged)

---

[changeset-bot]

⚠️ No Changeset found

Latest commit: 19f6d4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[workers-devprod]

Codeowners approval required for this PR:

• ✅ @cloudflare/wrangler

Show detailed file reviewers

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

[ask-bonk]

Everything checks out. The changes are:

1. Helper functions (framework-helpers.ts, workers-helpers.ts): Replace module-level import { expect } from "vitest" with import type { ExpectStatic } from "vitest", and add expect: ExpectStatic as a parameter to functions that use expect. The ExpectStatic type is the correct type for the test context's expect.

2. Test files (frameworks.test.ts, workers.test.ts): Pass the test-context expect to the updated helper functions.

3. to-exist.ts: Keeps the disable comment (necessarily) but adds a justification suffix (-- We need to import...), which is good practice.

4. mocks.ts: Replaces expect.fail(...) with throw new Error(...) to eliminate the expect import. These are guard functions for developer errors, and throw new Error is a correct and semantically appropriate replacement.

No logic bugs, no missed call sites, no type mismatches.

LGTM

github run

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13245

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13245

miniflare

npm i https://pkg.pr.new/miniflare@13245

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13245

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13245

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13245

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13245

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13245

wrangler

npm i https://pkg.pr.new/wrangler@13245

commit: 19f6d4b

[workers-devprod]

Codeowners reviews satisfied