Skip to content

Return an error instead of panicking on fixed-length-list size overflow - #2643

Merged
alexcrichton merged 2 commits into
bytecodealliance:mainfrom
zikk090:fix/sizealign-fixed-length-list-overflow
Sep 8, 2026
Merged

alexcrichton merged 2 commits into
bytecodealliance:mainfrom
zikk090:fix/sizealign-fixed-length-list-overflow

Conversation

@zikk090

@zikk090 zikk090 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

SizeAlign::fill (and its internal calculate helper) computed the size of a FixedLengthList as element_size * length via checked_mul(..).unwrap(), which panics when the multiplication overflows usize. Since list<T, N> places no upper bound on N in the WIT text format (unlike the component binary format, which bounds it to MAX_WASM_FIXED_LENGTH_LIST_ELEMENTS), a WIT document with two nested fixed-length lists of a non-trivial element type is enough to overflow the multiplication and abort the process, in a release build too.

This changes SizeAlign::fill/calculate to return anyhow::Result and propagates that outward through wit-dylib's Adapter::encode, create, and create_with_metadata, and their two call sites (the wasm-tools wit-dylib CLI subcommand and the wit-dylib test-programs harness). A oversized fixed-length list now surfaces as a normal error instead of aborting:

$ wasm-tools wit-dylib poc.wit
error: size of fixed-length list of 4294967295 elements overflows
the target architecture's address space

Adds a regression test covering both the overflow case (now returns Err) and a benign nested fixed-length list (still computes correctly).

Fixes #2637

`SizeAlign::fill` (and its internal `calculate` helper) computed the
size of a `FixedLengthList` as `element_size * length` via
`checked_mul(..).unwrap()`, which panics when the multiplication
overflows `usize`. Since `list<T, N>` places no upper bound on `N` in
the WIT text format (unlike the component binary format, which bounds
it to `MAX_WASM_FIXED_LENGTH_LIST_ELEMENTS`), a WIT document with two
nested fixed-length lists of a non-trivial element type is enough to
overflow the multiplication and abort the process, in a release build
too.

This changes `SizeAlign::fill`/`calculate` to return `anyhow::Result`
and propagates that outward through `wit-dylib`'s `Adapter::encode`,
`create`, and `create_with_metadata`, and their two call sites (the
`wasm-tools wit-dylib` CLI subcommand and the wit-dylib test-programs
harness). A oversized fixed-length list now surfaces as a normal
error instead of aborting:

    $ wasm-tools wit-dylib poc.wit
    error: size of fixed-length list of 4294967295 elements overflows
    the target architecture's address space

Adds a regression test covering both the overflow case (now returns
`Err`) and a benign nested fixed-length list (still computes
correctly).

Fixes bytecodealliance#2637
@zikk090
zikk090 requested a review from a team as a code owner September 8, 2026 19:47
@zikk090
zikk090 requested review from dicej and removed request for a team September 8, 2026 19:47

@pchickey pchickey left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please fix the error discovered by the clippy CI job. The other failure appears spurrious

find_signed_load's test helper still called super::create() as if it
returned Vec<u8> directly; it now returns anyhow::Result<Vec<u8>>.
Caught by CI's clippy job (which builds --all-targets, unlike my local
clippy run that only covered the lib). Did an exhaustive grep across
the whole workspace afterward for every other Adapter/SizeAlign call
site to confirm this was the only one missed.
@alexcrichton
alexcrichton added this pull request to the merge queue Sep 8, 2026
Merged via the queue into bytecodealliance:main with commit 138f801 Sep 8, 2026
37 checks passed
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
wasm-tools 1.259.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What's Changed
* Refactor name resolution of components in the text format by @alexcrichton in bytecodealliance/wasm-tools#2621
* Import component spec tests as a submodule and run them. by @alexcrichton in bytecodealliance/wasm-tools#2623
* Fix name uniqueness with methods/interfaces by @alexcrichton in bytecodealliance/wasm-tools#2625
* Add compact import generation in wasm-smith by @chacailline in bytecodealliance/wasm-tools#2627
* Drop hyphens when testing equality of kebab names by @alexcrichton in bytecodealliance/wasm-tools#2626
* Enable wide-arithmetic by default in wasm-smith by @alexcrichton in bytecodealliance/wasm-tools#2628
* Validate the size of defined component types by @alexcrichton in bytecodealliance/wasm-tools#2624
* Update Wasmtime used in testing/fuzzing by @alexcrichton in bytecodealliance/wasm-tools#2629
* Fix text format outer aliases from recent refactor by @alexcrichton in bytecodealliance/wasm-tools#2631
* Remove `cancellable` immediate from component model intrinsics by @alexcrichton in bytecodealliance/wasm-tools#2630
* Start requiring "strict" indices in the text format by @alexcrichton in bytecodealliance/wasm-tools#2633
* Enable the `cm-implements` and `cm-map` features by default by @alexcrichton in bytecodealliance/wasm-tools#2634
* Clamp sizes of element segments in wasm-smith by @alexcrichton in bytecodealliance/wasm-tools#2632
* Fix wit-smith generating huge types by @alexcrichton in bytecodealliance/wasm-tools#2636
* Fix disallow_traps in wasm-smith with custom page sizes by @alexcrichton in bytecodealliance/wasm-tools#2635
* Resolve Cargo warnings on nightly by @alexcrichton in bytecodealliance/wasm-tools#2642
* Return an error instead of panicking on fixed-length-list size overflow by @zikk090 in bytecodealliance/wasm-tools#2643
* Try to improve performance of `deinline_import_export` by @alexcrichton in bytecodealliance/wasm-tools#2647
* Document a non-obvious method argument by @alexcrichton in bytecodealliance/wasm-tools#2645
* wasm-wave: Clean up syntax docs by @lann in bytecodealliance/wasm-tools#2644
* Update dependency major tracks by @alexcrichton in bytecodealliance/wasm-tools#2649
* Release wasm-tools 1.259.0 by @github-actions[bot] in bytecodealliance/wasm-tools#2650

## New Contributors
* @chacailline made their first contribution in bytecodealliance/wasm-tools#2627
* @zikk090 made their first contribution in bytecodealliance/wasm-tools#2643

**Full Changelog**: https://github.com/bytecodealliance/wasm-tools/compare/v1.258.0...v1.259.0</pre>
  <p>View the full release notes at <a href="https://github.com/bytecodealliance/wasm-tools/releases/tag/v1.259.0">https://github.com/bytecodealliance/wasm-tools/releases/tag/v1.259.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!20061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integer overflow panic in wit-parser SizeAlign for nested fixed-length lists

3 participants