Skip to content

Fix name uniqueness with methods/interfaces - #2625

Merged
pchickey merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:fix-resource-and-interface-names
Aug 26, 2026
Merged

pchickey merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:fix-resource-and-interface-names

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

The hashing/equality done by wasmparser for resource methods and interface names didn't take into account the hashing of KebabStr, notably lowercasing, meaning that methods/interfaces which should clash did not actually clash. This is fixed here with custom trait impls that delegate to KebabStr versions.

The hashing/equality done by wasmparser for resource methods and
interface names didn't take into account the hashing of `KebabStr`,
notably lowercasing, meaning that methods/interfaces which should clash
did not actually clash. This is fixed here with custom trait impls that
delegate to `KebabStr` versions.
@alexcrichton
alexcrichton requested a review from a team as a code owner August 26, 2026 19:48
@alexcrichton
alexcrichton requested review from dicej and removed request for a team August 26, 2026 19:48
@pchickey
pchickey added this pull request to the merge queue Aug 26, 2026
Merged via the queue into bytecodealliance:main with commit e1ab7f1 Aug 26, 2026
37 checks passed
@alexcrichton
alexcrichton deleted the fix-resource-and-interface-names branch August 26, 2026 20:58
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
wasm-tools 1.259.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What's Changed
* Refactor name resolution of components in the text format by @alexcrichton in bytecodealliance/wasm-tools#2621
* Import component spec tests as a submodule and run them. by @alexcrichton in bytecodealliance/wasm-tools#2623
* Fix name uniqueness with methods/interfaces by @alexcrichton in bytecodealliance/wasm-tools#2625
* Add compact import generation in wasm-smith by @chacailline in bytecodealliance/wasm-tools#2627
* Drop hyphens when testing equality of kebab names by @alexcrichton in bytecodealliance/wasm-tools#2626
* Enable wide-arithmetic by default in wasm-smith by @alexcrichton in bytecodealliance/wasm-tools#2628
* Validate the size of defined component types by @alexcrichton in bytecodealliance/wasm-tools#2624
* Update Wasmtime used in testing/fuzzing by @alexcrichton in bytecodealliance/wasm-tools#2629
* Fix text format outer aliases from recent refactor by @alexcrichton in bytecodealliance/wasm-tools#2631
* Remove `cancellable` immediate from component model intrinsics by @alexcrichton in bytecodealliance/wasm-tools#2630
* Start requiring "strict" indices in the text format by @alexcrichton in bytecodealliance/wasm-tools#2633
* Enable the `cm-implements` and `cm-map` features by default by @alexcrichton in bytecodealliance/wasm-tools#2634
* Clamp sizes of element segments in wasm-smith by @alexcrichton in bytecodealliance/wasm-tools#2632
* Fix wit-smith generating huge types by @alexcrichton in bytecodealliance/wasm-tools#2636
* Fix disallow_traps in wasm-smith with custom page sizes by @alexcrichton in bytecodealliance/wasm-tools#2635
* Resolve Cargo warnings on nightly by @alexcrichton in bytecodealliance/wasm-tools#2642
* Return an error instead of panicking on fixed-length-list size overflow by @zikk090 in bytecodealliance/wasm-tools#2643
* Try to improve performance of `deinline_import_export` by @alexcrichton in bytecodealliance/wasm-tools#2647
* Document a non-obvious method argument by @alexcrichton in bytecodealliance/wasm-tools#2645
* wasm-wave: Clean up syntax docs by @lann in bytecodealliance/wasm-tools#2644
* Update dependency major tracks by @alexcrichton in bytecodealliance/wasm-tools#2649
* Release wasm-tools 1.259.0 by @github-actions[bot] in bytecodealliance/wasm-tools#2650

## New Contributors
* @chacailline made their first contribution in bytecodealliance/wasm-tools#2627
* @zikk090 made their first contribution in bytecodealliance/wasm-tools#2643

**Full Changelog**: https://github.com/bytecodealliance/wasm-tools/compare/v1.258.0...v1.259.0</pre>
  <p>View the full release notes at <a href="https://github.com/bytecodealliance/wasm-tools/releases/tag/v1.259.0">https://github.com/bytecodealliance/wasm-tools/releases/tag/v1.259.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!20061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants