fix(build): allow vendored opus to configure under CMake 4#1763
Merged
wpfleger96 merged 1 commit intoJul 12, 2026
Conversation
CMake 4 (hermit pins 4.3.1) removed compatibility with projects declaring cmake_minimum_required < 3.5, so audiopus_sys's vendored opus fails to configure on any machine without a system libopus, breaking local desktop builds (just dev, rust-analyzer). CI already sets this per step; the shared cargo config extends the same workaround to every local invocation, and an existing environment value still takes precedence.
wpfleger96
pushed a commit
that referenced
this pull request
Jul 12, 2026
* origin/main: fix(desktop): correct provider and model handling in agent config dialogs (#1764) fix(desktop): cascade persona deletes and restart agents on global config save (#1766) fix(desktop): make doctor installs retryable with per-runtime progress and auth status (#1765) fix(codex): swap to @agentclientprotocol/codex-acp 1.x + detect outdated adapter (#1750) Fix oversized mobile Manage channel sheet (#1774) fix(desktop): show thread replies loader (#1773) fix(build): allow vendored opus to configure under CMake 4 (#1763) fix(desktop): restore multi-image mosaic galleries (#1769) Group channel membership events (#1713) Fix desktop launch motion and reaction spacing (#1717) fix(desktop): align sidebar search across themes (#1712) fix(desktop): Buzz theme flicker, white bar & accent-picker motion (#1681) fix(mobile): highlight full multi-word mentions (#1762) [BOT-1264] fix(mobile): #channel tags not tappable (#1695) feat(desktop): surface Team Instructions as distinct observer section (#1759) # Conflicts: # desktop/playwright.config.ts
wpfleger96
pushed a commit
that referenced
this pull request
Jul 12, 2026
* origin/main: fix(desktop): correct provider and model handling in agent config dialogs (#1764) fix(desktop): cascade persona deletes and restart agents on global config save (#1766) fix(desktop): make doctor installs retryable with per-runtime progress and auth status (#1765) fix(codex): swap to @agentclientprotocol/codex-acp 1.x + detect outdated adapter (#1750) Fix oversized mobile Manage channel sheet (#1774) fix(desktop): show thread replies loader (#1773) fix(build): allow vendored opus to configure under CMake 4 (#1763) fix(desktop): restore multi-image mosaic galleries (#1769) Group channel membership events (#1713) Fix desktop launch motion and reaction spacing (#1717) fix(desktop): align sidebar search across themes (#1712) fix(desktop): Buzz theme flicker, white bar & accent-picker motion (#1681) fix(mobile): highlight full multi-word mentions (#1762) [BOT-1264] fix(mobile): #channel tags not tappable (#1695) feat(desktop): surface Team Instructions as distinct observer section (#1759) Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com> # Conflicts: # desktop/playwright.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just devfails on any machine without a systemlibopus:audiopus_sys's build script falls back to compiling its vendored opus with CMake, whoseCMakeLists.txtdeclarescmake_minimum_required(VERSION 3.1), and the hermit-pinned CMake 4.3.1 removed compatibility with declared minimums below 3.5:CI already sets
CMAKE_POLICY_VERSION_MINIMUM: "3.5"on every Tauri-crate build step inci.ymlandrelease.yml. This applies the same workaround to local builds via[env]in the shared.cargo/config.toml, coveringjust dev, directcargoinvocations,rust-analyzer, and git worktrees.A value already present in the environment takes precedence, so CI is unaffected; CMake < 4 ignores the variable, and machines with a system
libopusnever reach the CMake path at all.audiopus_sys0.2.2 is the latest release of a dormant crate, so there is no upstream fix to upgrade into.