fix(mobile): highlight full multi-word mentions#1762
Merged
Conversation
Co-authored-by: npub1shglkdhngx3hrnhf4gf8vhpqdrmeludctechdvpwd3988zzs7ncq2cmtxu <85d1fb36f341a371cee9aa12765c2068f79ff1b85e7176b02e6c4a738850f4f0@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1shglkdhngx3hrnhf4gf8vhpqdrmeludctechdvpwd3988zzs7ncq2cmtxu <85d1fb36f341a371cee9aa12765c2068f79ff1b85e7176b02e6c4a738850f4f0@sprout-oss.stage.blox.sqprod.co>
Contributor
Author
|
@codex review |
Contributor
Author
|
@builderbot review |
|
To use Codex here, create a Codex account and connect to github. |
brow
commented
Jul 12, 2026
Co-authored-by: npub1shglkdhngx3hrnhf4gf8vhpqdrmeludctechdvpwd3988zzs7ncq2cmtxu <85d1fb36f341a371cee9aa12765c2068f79ff1b85e7176b02e6c4a738850f4f0@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1shglkdhngx3hrnhf4gf8vhpqdrmeludctechdvpwd3988zzs7ncq2cmtxu <85d1fb36f341a371cee9aa12765c2068f79ff1b85e7176b02e6c4a738850f4f0@sprout-oss.stage.blox.sqprod.co>
brow
commented
Jul 12, 2026
Co-authored-by: npub1shglkdhngx3hrnhf4gf8vhpqdrmeludctechdvpwd3988zzs7ncq2cmtxu <85d1fb36f341a371cee9aa12765c2068f79ff1b85e7176b02e6c4a738850f4f0@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1shglkdhngx3hrnhf4gf8vhpqdrmeludctechdvpwd3988zzs7ncq2cmtxu <85d1fb36f341a371cee9aa12765c2068f79ff1b85e7176b02e6c4a738850f4f0@sprout-oss.stage.blox.sqprod.co>
Collaborator
|
@codex please review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
wesbillman
approved these changes
Jul 12, 2026
wpfleger96
pushed a commit
that referenced
this pull request
Jul 12, 2026
* origin/main: fix(desktop): correct provider and model handling in agent config dialogs (#1764) fix(desktop): cascade persona deletes and restart agents on global config save (#1766) fix(desktop): make doctor installs retryable with per-runtime progress and auth status (#1765) fix(codex): swap to @agentclientprotocol/codex-acp 1.x + detect outdated adapter (#1750) Fix oversized mobile Manage channel sheet (#1774) fix(desktop): show thread replies loader (#1773) fix(build): allow vendored opus to configure under CMake 4 (#1763) fix(desktop): restore multi-image mosaic galleries (#1769) Group channel membership events (#1713) Fix desktop launch motion and reaction spacing (#1717) fix(desktop): align sidebar search across themes (#1712) fix(desktop): Buzz theme flicker, white bar & accent-picker motion (#1681) fix(mobile): highlight full multi-word mentions (#1762) [BOT-1264] fix(mobile): #channel tags not tappable (#1695) feat(desktop): surface Team Instructions as distinct observer section (#1759) # Conflicts: # desktop/playwright.config.ts
wpfleger96
pushed a commit
that referenced
this pull request
Jul 12, 2026
* origin/main: fix(desktop): correct provider and model handling in agent config dialogs (#1764) fix(desktop): cascade persona deletes and restart agents on global config save (#1766) fix(desktop): make doctor installs retryable with per-runtime progress and auth status (#1765) fix(codex): swap to @agentclientprotocol/codex-acp 1.x + detect outdated adapter (#1750) Fix oversized mobile Manage channel sheet (#1774) fix(desktop): show thread replies loader (#1773) fix(build): allow vendored opus to configure under CMake 4 (#1763) fix(desktop): restore multi-image mosaic galleries (#1769) Group channel membership events (#1713) Fix desktop launch motion and reaction spacing (#1717) fix(desktop): align sidebar search across themes (#1712) fix(desktop): Buzz theme flicker, white bar & accent-picker motion (#1681) fix(mobile): highlight full multi-word mentions (#1762) [BOT-1264] fix(mobile): #channel tags not tappable (#1695) feat(desktop): surface Team Instructions as distinct observer section (#1759) Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com> # Conflicts: # desktop/playwright.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Mobile currently highlights only the first name in a full-name mention and leaves a duplicate surname as plain text.
How is it tested?
Added tests:
MessageContent @mentionsFocused mobile validation and static analysis pass.