Fix printing bugs when using no-overwrite flag#9717
Merged
aemous merged 11 commits intoaws:s3-no-overwritefrom Oct 8, 2025
Merged
Fix printing bugs when using no-overwrite flag#9717aemous merged 11 commits intoaws:s3-no-overwritefrom
aemous merged 11 commits intoaws:s3-no-overwritefrom
Conversation
kdaily
requested changes
Sep 26, 2025
Member
kdaily
left a comment
There was a problem hiding this comment.
This LGTM. I ran it through the test suite after pulling in the latest changes from v2 and that was OK. I think we should add a test to exercise the newly added SkipFileResult?
Member
|
LGTM! Lets make sure to clean up the commit history or squash before merging, preferably getting some of the details from the description on this PR into the final commit(s). Thanks! |
kdaily
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
--no-overwriteparameter where the last character printed to CLI would be a carriage return (\r), which would cause incompatibility with some terminal program (e.g. Windows Powershell).ResultPrinter.SkipFileResult).ResultPrinterso that they can opt-out of resettingprogress_lengthto 0. Useful for result handlers that do not print newlines (e.g. newSkipFileResult).Description of tests:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.