Improve User Experience in Linux and Windows#9655
Closed
rakshil14-2 wants to merge 3 commits into
Closed
Conversation
Member
|
Fixed via #9717 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
In Current Implementation all the events(Success, Failure, Warning) are handled by result queue. Where every file_transferred is accounted for any of the three events. In case of
--includeand--exclude, the files which are supposed to be filtered out are done before initiating the actual transfer hence, they is no issue in those cases.While in case of
no-overwritetransfer actually happens so for the files which are skipped a new result queue must be added and those files that are skipped must be properly handled. Here is the example how we can deal with the solution.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.