cloudformation deploy: Use parameter default value only on stack creation - #2573
Merged
Conversation
…tion There are four state combinations: YES Override + YES Stack: Use overriden value YES Override + NO Stack: Use overriden value NO Override + YES Stack: Set UsePreviousValue to True ^^ This commit fixes this case. Earlier we were letting CloudFormation pickup default value from template NO Override + NO Stack: Skip parameter to force CloudFormation to use template default value. UsePreviousValue=True will fail here because stack does not have any previous state.
Contributor
Author
|
Fixes #2460 |
dstufft
approved these changes
Apr 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are four state combinations:
YES Override + YES Stack: Use overriden value
YES Override + NO Stack: Use overriden value
NO Override + YES Stack: Set UsePreviousValue to True
^^ This commit fixes this case. Earlier we were letting CloudFormation pickup default value from template
NO Override + NO Stack: Skip parameter to force CloudFormation to use template default value. UsePreviousValue=True will fail here because stack does not have any previous state.