cloudformation deploy: Use template parameter default value only on stack creation - #2567
Closed
sanathkr wants to merge 9 commits into
Closed
cloudformation deploy: Use template parameter default value only on stack creation#2567sanathkr wants to merge 9 commits into
sanathkr wants to merge 9 commits into
Conversation
merging from awscli
…tion There are four state combinations: YES Override + YES Stack: Use overriden value YES Override + NO Stack: Use overriden value NO Override + YES Stack: Set UsePreviousValue to True ^^ This commit fixes this case. Earlier we were letting CloudFormation pickup default value from template NO Override + NO Stack: Skip parameter to force CloudFormation to use template default value. UsePreviousValue=True will fail here because stack does not have any previous state.
Contributor
Author
|
Build is failing for python2.6 on an unrelated test: |
Contributor
It is now being used by more than just s3, therefore this moves it up to the customizations directory.
This injects a scheme into some compared urls as urlsplit will fail to properly split if the scheme is absent in some versions.
Codecov Report
@@ Coverage Diff @@
## develop #2567 +/- ##
===========================================
- Coverage 95.57% 95.57% -0.01%
===========================================
Files 151 151
Lines 11782 11781 -1
===========================================
- Hits 11261 11260 -1
Misses 521 521
Continue to review full report at Codecov.
|
Contributor
|
It looks like this didn't get rebased cleanly? |
Contributor
|
Yea its got all the rds customizations in there. |
Contributor
Author
|
Rebased again and pushed in a new branch at #2573 |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
* Bumped aws-sam-translator to 1.27.0 * Bumped SAM CLI Version to 1.3.0 * Updated Reproducible Requirements * Added Close to Packaged File * Removed Debug Prints * Removed Debug Vars * Removed Another Debug Print * Formatting Co-authored-by: Wilton Wang <weichw@dev-dsk-weichw-2c-871e54ff.us-west-2.amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2460
There are four state combinations:
YES Override + YES Stack: Use overriden value
YES Override + NO Stack: Use overriden value