fix(tui): guard against null/undefined MCP status in reactive computations

[KeWang0622]

Issue for this PR

Closes #22102
Closes #21931
Closes #21645
Closes #21449
Closes #21290
Closes #20806

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

During TUI bootstrap, sync.tsx fetches MCP status from the server and updates the store via:

sdk.client.mcp.status({ workspace }).then((x) => setStore("mcp", reconcile(x.data!)))

When x.data is null or undefined (e.g., the server hasn't finished initializing, a network hiccup, or an SDK edge case), reconcile(undefined) sets store.mcp to undefined. Every component that then calls Object.entries(sync.data.mcp), Object.keys(...), or Object.values(...) throws:

TypeError: Object.entries requires that input parameter not be null or undefined

This crash has been reported at least 6 times (#22102, #21931, #21645, #21449, #21290, #20806), primarily on Windows but reproducible on any platform with the right timing.

Root fix (sync.tsx): replace x.data! with x.data ?? {} so the store is never set to undefined.

Defense-in-depth (5 consumption sites): add ?? {} or ?. at every call site that touches sync.data.mcp, so even if the store value is transiently undefined during a reactive recomputation, no component crashes. This matches the pattern already used in dialog-mcp.tsx (line 35: mcpData ?? {}).

Files changed

File	Change
context/sync.tsx	x.data! → x.data ?? {} (root cause)
component/dialog-status.tsx	sync.data.mcp → sync.data.mcp ?? {} (3 sites)
routes/session/footer.tsx	sync.data.mcp → sync.data.mcp ?? {} (2 sites)
plugin/api.tsx	sync.data.mcp → sync.data.mcp ?? {} (1 site)
context/local.tsx	sync.data.mcp[name] → sync.data.mcp?.[name] (2 sites)

How did you verify your code works?

• bun test — all 1893 tests pass (0 fail)
• bun typecheck — all 13 packages pass (the husky pre-push hook ran this automatically)
• Manually inspected every sync.data.mcp access in the TUI codebase to confirm all are now guarded

Screenshots / recordings

N/A — not a visual change; this prevents a crash.

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

I found potentially related PRs:

PR #20444: fix(tui): add null guards for lsp and mcp state data

#20444

• This appears to address a similar issue with null guards for MCP state data in the TUI

PR #21246: fix(tui): guard against undefined agents and mcp state during bootstrap

#21246

• This also covers guarding against undefined MCP state during bootstrap, which is directly related to the bootstrap timing issue mentioned in PR fix(tui): guard against null/undefined MCP status in reactive computations #22206

Both PRs are addressing similar null/undefined guard issues in MCP state handling during TUI initialization, though PR #22206 appears to be a more comprehensive fix across multiple consumption sites.

[KeWang0622]

Thanks for flagging the related PRs!

How this PR differs from #20444 and #21246:

• fix(tui): add null guards for lsp and mcp state data #20444 adds ?? {} guards at 3 consumption sites — our PR covers all the same sites plus more.
• fix(tui): guard against undefined agents and mcp state during bootstrap #21246 adds agent-related null guards (dialog-agent.tsx, agent cycling) that are complementary — different concern.
• This PR (fix(tui): guard against null/undefined MCP status in reactive computations #22206) is the only one that fixes the root cause in context/sync.tsx where reconcile(x.data!) sets the store to undefined when the MCP status API returns null. The other two PRs only patch downstream consumption sites.

This PR and #21246 are complementary (MCP root cause + agent guards). #20444 is fully subsumed by this one.

[KeWang0622]

Friendly bump — happy to rebase or split if it helps review. TL;DR: this fixes the root cause in context/sync.tsx, where reconcile(x.data!) writes undefined into the store on null API responses. #20444 and #21246 only patch downstream consumption sites. Let me know if I can clarify or adjust anything.

[rekram1-node]

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

• The PR was created more than 1 month ago
• The PR had fewer than 2 positive reactions
• Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.