fix(tui): guard against undefined agents and mcp state during bootstrap

[surajrav]

Issue for this PR

#20588, #20628.

Closes #
Fixes #20588, #20628.

Type of change

• Bug fix

What does this PR do?

• Guard TUI components against undefined/empty sync.data.agent and sync.data.mcp during async bootstrap
• Prevents fatal crash when plugins (e.g. oh-my-openagent) slow down agent/MCP resolution

Disclaimer: I made this fix with the help of opencode itself with claude opus 4.6, but I have spent time understanding what it is doing AND tested it to work in my local setup
All changes are defensive null guards. No behavioral change when data is present.

Problem

The TUI crashes with a fatal TypeError when plugins like oh-my-openagent are loaded:
TypeError: undefined is not an object (evaluating 'list2().length')
at (/$bunfs/root/src/index.js:496761:41)
at runComputation (/$bunfs/root/src/index.js:472905:24)
at updateComputation (/$bunfs/root/src/index.js:472888:17)
at readSignal (/$bunfs/root/src/index.js:472810:24)
at (/$bunfs/root/src/index.js:473750:49)
at runComputation (/$bunfs/root/src/index.js:472905:24)
at updateComputation (/$bunfs/root/src/index.js:472888:17)
at createMemo (/$bunfs/root/src/index.js:472393:22)
at Show (/$bunfs/root/src/index.js:473750:36)
Running from source reveals the crash originates in footer.tsx:30 and local.tsx:43.

Root Cause

SyncProvider initializes sync.data with empty defaults (agent: [], mcp: {}) and calls bootstrap() asynchronously via onMount. SolidJS continues rendering child components (LocalProvider, footer, sidebar) before bootstrap resolves.

Without plugins, the server responds fast enough that the timing window is negligible. When oh-my-openagent is loaded, its config handler performs model resolution, skill discovery, and provider caching, which delays the sdk.client.app.agents() response. This widens the window where sync.data fields are still in their initial empty state, and the TUI crashes accessing:

• agents()[0].name — agents() is [], so agents()[0] is undefined
• state.mcp().length — sync.data.mcp can be undefined after reconcile()
• local.agent.current().name — current() returns undefined when agents list is empty

Files Changed and Why

File	Line	Before	After	Why
context/local.tsx	43	agents()[0].name	agents()[0]?.name ?? ""	agents() is [] before bootstrap resolves, so agents()[0] is undefined. Accessing .name on undefined throws the fatal TypeError.
context/local.tsx	77	setAgentStore("current", value.name)	if (value) setAgentStore("current", value.name)	agents()[next] can be undefined if the list is empty when user cycles agents via keybind before bootstrap completes.
plugin/api.tsx	190	Object.entries(sync.data.mcp)	if (!sync.data.mcp) return [] before the Object.entries call	sync.data.mcp can be undefined after reconcile(undefined) from a server response where x.data is undefined. Object.entries(undefined) throws.
feature-plugins/home/footer.tsx	22	props.api.state.mcp()	props.api.state.mcp() ?? []	This is the exact crash site from the stack trace (list2().length). state.mcp() returns undefined before bootstrap, and line 23 calls .length on it.
feature-plugins/sidebar/mcp.tsx	9	props.api.state.mcp()	props.api.state.mcp() ?? []	Same pattern as footer — sidebar MCP view calls .length, .filter(), .some() on the result, all of which crash on undefined.
component/dialog-agent.tsx	23	local.agent.current().name	local.agent.current()?.name ?? ""	current() returns agents().find(...) ?? agents()[0] — both return undefined when agents list is empty. Accessing .name crashes.

How did you verify your code works?

I ran opencode from my fork and didn't face the crash and got my prompt screen.

Screenshots / recordings

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potentially Related PR Found:

PR #17015: Fix/issue 16982 agent current undefined

• Fix/issue 16982 agent current undefined #17015
• This PR addresses a similar issue with agent.current() returning undefined, which aligns with one of the fixes in the current PR (PR fix(tui): guard against undefined agents and mcp state during bootstrap #21246). Both address null safety for agent state.

Note: The current PR is explicitly addressing issues #20588 and #20628, and the search results predominantly return PR #21246 itself, which indicates no other open PRs are currently tackling the same defensive null guards and bootstrap timing issues.

[github-actions]

Thanks for updating your PR! It now meets our contributing guidelines. 👍

[rekram1-node]

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

• The PR was created more than 1 month ago
• The PR had fewer than 2 positive reactions
• Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.