This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(fakeAsyncTest): fix #937, let user be able to customize testable macroTask#938
Merged
Conversation
mhevery
approved these changes
Dec 27, 2017
mhevery
pushed a commit
to sandersn/zone.js
that referenced
this pull request
Dec 27, 2017
…stable macroTask (angular#938) * fix(fakeAsyncTest): fix angular#937, let user be able to customize testable macroTask * add global flag to define fakeAsyncTest macroTaskOptions * support set callback arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #937
let user be able to customize which macroTasks can be test with
fakeAsyncTestSpec.for example, in #937, user want to test
cavans.toBlob(). with this PR, user can achieve it in two ways.FakeAsyncTestSpecconstructorFakeAsyncTestSpecinitialize process, so user can also define a global variable before loadfakeAsyncTest.@vikerman , please review.
And the CI will pass after #935 is merged (because rxjs 5.5.0's issue).