This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(timer): setInterval should not auto cancel after callback invoked, fix rxjs version to pass CI#935
Merged
mhevery merged 3 commits intoangular:masterfrom Dec 27, 2017
Merged
Conversation
c850df6 to
5ceb5fc
Compare
adrienverge
approved these changes
Nov 29, 2017
adrienverge
left a comment
There was a problem hiding this comment.
Hi @JiaLiPassion,
I have tested this PR and I confirm it solves the setInterval() / clearInterval() problem (issues #934 and #945)!
Thanks a lot 👍
Do we need to wait for rxjs to publish a new version to merge this, or not?
This was referenced Nov 29, 2017
Collaborator
Author
|
@adrienverge, thank you for confirm, we don't need to wait for rxjs new version, because |
|
Since |
Collaborator
Author
|
@sarunint , yes, I will update the |
mhevery
approved these changes
Dec 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #934.
setIntervalwill auto clear timerId after first time invoked.the issue was imported several versions ago, but it doesn't become a problem because we
return
ZoneTaskfromsetIntervalbeforezone.js 0.8.17, fromzone.js 0.8.18,setIntervalwill return the originaltimerId, so when we callclearIntervalthetimerIdhave been cleared, which will cause zone.jsonHasTasknot be called, thesetIntervaltask was always there.And will cause
ngZonenot stable.Also fix
rxjsversion to5.4.2to avoidkaramerror, I will continue to figure out how to resolvekaramtest error withrxjs 5.5.0.The issue is here, and it seems it will be fixed in
rxjs 5.5.1ReactiveX/rxjs#2971