This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Fix #546, #554, #555, the error should keep prototype chain and can be called without new#558
Closed
JiaLiPassion wants to merge 8 commits into
Closed
Fix #546, #554, #555, the error should keep prototype chain and can be called without new#558JiaLiPassion wants to merge 8 commits into
JiaLiPassion wants to merge 8 commits into
Conversation
…structor, and copy native error's properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the commit #547, the #546, error prototype issue was fixed, but a bigger issue occurs, that
Error object can be created with direct call.
And the #547 PR will break it, cause a lot of errors, such as #554, #555
In this new PR, I checked the this exists or not and checked the this is global or not (non strict mode). So it should fix both #546 and #554, #555.
Please review, Thank you.