v0.7+ - custom Error classes do not work as expected

[michaelbromley]

Zone.js version: 0.7.2

Setup:

class MyError extends Error {}
let error = new MyError();
console.log(error instanceof MyError);

Expected: logs true
Actual: logs false - error is an instance of Error, rather than MyError when zone.js is loaded in the app.

Demo: https://plnkr.co/edit/kSKVeuhIrMcluK1D9JSl?p=preview
Look in the console to see the erroneous behaviour, and then comment out the script tag including zone.js; and the correct behaviour will be observed in the console.

Replacing the version in the <script> tag with 0.6.26 in the above Plunker demo demonstrates correct behaviour - so this bug was introduced with v0.7+ it seems.

[JiaLiPassion]

The reason is ZoneAwareError override the global Error so the error prototype is NativeError's prototype, I would like to try to fix this one.

[chuckjaz]

Re-opening this bug as the fix was reverted.

This change broke an assumption that calling Error directly is valid and, in particular, broke rxjs. See https://plnkr.co/edit/SYPR2SRi0xayQ693jJAB?p=preview for an example of the break.

[michaelbromley]

Thanks all for the fix. I can see a lot of work and thought has gone into it.

Any idea when this will be available for release? This is the only thing stopping me from updating a project which is stuck on rc.4 to the latest Angular release.