fix(@angular/cli): fix PWD in cygwin#10778
Conversation
| process.env.PWD = path.normalize(process.env.PWD || process.cwd()); | ||
| // Ensure the environment variables for dynamic paths are set. | ||
| // We can't use the existing process.env.PWD because it can be incorrect in shells like cygwin. | ||
| process.env.PWD = process.cwd(); |
There was a problem hiding this comment.
This is only used here: https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/models/schematic-command.ts#L100
If that is changed to use process.cwd(), the line here can be removed. The following line appears completely unused as well.
filipesilva
force-pushed
the
schematics-cygwin
branch
from
e493830 to
bd6f462
Compare
Brocco
left a comment
Brocco
left a comment
There was a problem hiding this comment.
That value is also set for tests (done originally for consistency) So please also remove this reference.
angular-cli/tests/e2e/utils/process.ts
Line 174 in 89242be
filipesilva
force-pushed
the
schematics-cygwin
branch
from
bd6f462 to
2996aaa
Compare
|
@Brocco done. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
Fix #10232