Skip to content

check for configured debugger before start to provide a nicer error message - #401

Merged
GitMensch merged 2 commits into
masterfrom
check-debugger
Feb 7, 2024
Merged

GitMensch merged 2 commits into
masterfrom
check-debugger

Conversation

@GitMensch

Copy link
Copy Markdown
Collaborator

This is a side issue to #398 (I'd like to provide a similar PR for that).

As I'm currently only "on the browser" I have neither tested that nor run prettier, but I think the current state is enough for a first review.

@codecov-commenter

codecov-commenter commented Jun 6, 2023 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.55%. Comparing base (9fb2875) to head (8c926ca).
⚠️ Report is 39 commits behind head on master.

Files with missing lines Patch % Lines
src/gdb.ts 0.00% 10 Missing ⚠️
src/lldb.ts 0.00% 10 Missing ⚠️
src/mago.ts 0.00% 10 Missing ⚠️
src/mibase.ts 0.00% 6 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   20.89%   20.55%   -0.34%     
==========================================
  Files          14       14              
  Lines        1771     1800      +29     
  Branches      381      388       +7     
==========================================
  Hits          370      370              
- Misses       1356     1385      +29     
  Partials       45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitMensch

Copy link
Copy Markdown
Collaborator Author

That change is easy to test, so those should be added before pulling, too.

@GitMensch

Copy link
Copy Markdown
Collaborator Author

@WebFreak001 Should I rebase - or isn't this likely to get merged?

@WebFreak001

Copy link
Copy Markdown
Owner

feel free to merge your own commits as well, I think error message improvements and such are always very useful

@GitMensch
GitMensch merged commit 9ecddaa into master Feb 7, 2024
@GitMensch
GitMensch deleted the check-debugger branch February 7, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants