bad error message if cwd points to non-existing directory #398

Activity

1. WebFreak001 commented on May 23, 2023

   

   WebFreak001

   on May 23, 2023

   Owner

   More actions

   the simplest option would just be changing the error message to also include a mention about cwd

   😄React with 😄1Reacted by Simon Sobisch
2. GitMensch commented on Jun 6, 2023

   

   GitMensch

   on Jun 6, 2023

   CollaboratorAuthor

   More actions

   Would you mind if I add a check using

   function isDirectoryAvailable(directoryPath: string): Error | null {
     try {
       fs.accessSync(directoryPath, fs.constants.F_OK);
       return null; // Directory exists
     } catch (error) {
       return error; // Return the error object
     }
   }

   to #401 and have a "combined" PR for these issues (this would also go to mibase and be called directly after checking the debugger - as the ChildProcess.spawn is used in every case and that takes the cwd.

   ...hm but the ssh one - did I miss that case when checking for the debugger and should extra handle that for both checks?