feat: include user's OS and shell in LLM prompt#62
Open
JonathanRohland-TNG wants to merge 1 commit intomainfrom
Open
feat: include user's OS and shell in LLM prompt#62JonathanRohland-TNG wants to merge 1 commit intomainfrom
JonathanRohland-TNG wants to merge 1 commit intomainfrom
Conversation
…ommand generation Signed-off-by: Jonathan Rohland <jonathan.rohland@tngtech.com>
Collaborator
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Shell Detection Fails in Unset Environments
When the $SHELL environment variable is unset or empty, basename "$SHELL" returns ".". This incorrect value is then passed to the LLM as the user's shell (e.g., "shell is '.'"), leading to the LLM generating inappropriate or incorrect command suggestions. This can occur in environments where $SHELL is not reliably set, such as containers or minimal shells.
please.sh#L33-L34
Lines 33 to 34 in 6a0045a
Was this report helpful? Give feedback by reacting with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an alternative take on the idea from #44 based on my review comment there: #44 (comment)