Skip to content

[format] cleanup libcpu/aarch64#8950

Merged
BernardXiong merged 6 commits intoRT-Thread:masterfrom
polarvid:shell/arm64-format
Jun 27, 2024
Merged

[format] cleanup libcpu/aarch64#8950
BernardXiong merged 6 commits intoRT-Thread:masterfrom
polarvid:shell/arm64-format

Conversation

@polarvid
Copy link
Copy Markdown
Contributor

@polarvid polarvid commented May 16, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Cleanup UP/MP codes for better maintainability.

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@polarvid polarvid force-pushed the shell/arm64-format branch 2 times, most recently from 6f36ceb to c3dbc0f Compare May 16, 2024 04:01
polarvid added 5 commits June 24, 2024 14:29
Signed-off-by: Shell <smokewood@qq.com>
Signed-off-by: Shell <smokewood@qq.com>
Signed-off-by: Shell <smokewood@qq.com>
Signed-off-by: Shell <smokewood@qq.com>
Signed-off-by: Shell <smokewood@qq.com>
@polarvid polarvid force-pushed the shell/arm64-format branch from c3dbc0f to 7a6b051 Compare June 24, 2024 06:29
@polarvid polarvid marked this pull request as ready for review June 24, 2024 06:50
@polarvid polarvid requested a review from BernardXiong as a code owner June 24, 2024 06:50
@BernardXiong BernardXiong merged commit 90917cc into RT-Thread:master Jun 27, 2024
messigogogo pushed a commit to messigogogo/rt-thread that referenced this pull request Jul 22, 2024
* [dfs] fixup compiler warning

Signed-off-by: Shell <smokewood@qq.com>

* [format] libcpu/arm64: separate context switching codes

Signed-off-by: Shell <smokewood@qq.com>

* [format] libcpu/arm64: separate vector

Signed-off-by: Shell <smokewood@qq.com>

* [format] libcpu/arm64: separate context_gcc.S

Signed-off-by: Shell <smokewood@qq.com>

* [format] libcpu/arm64: moving headers to include directory

Signed-off-by: Shell <smokewood@qq.com>

* style: replace tab with space

---------

Signed-off-by: Shell <smokewood@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants