[libcpu/arm64] add C11 atomic ticket spinlock#8882
Merged
BernardXiong merged 2 commits intoRT-Thread:masterfrom May 16, 2024
Merged
[libcpu/arm64] add C11 atomic ticket spinlock#8882BernardXiong merged 2 commits intoRT-Thread:masterfrom
BernardXiong merged 2 commits intoRT-Thread:masterfrom
Conversation
polarvid
force-pushed
the
shell/generic-spinlock
branch
4 times, most recently
from
b12a82d to
a9fc6aa
Compare
Replace the former implementation of flag-based spinlock which is unfair Besides, C11 atomic implementation is more readable (it's C anyway), and maintainable. Cause toolchain can use their builtin optimization and tune for different micro-architectures. For example armv8.5 introduces a better instruction. The compiler can help with that when it knows your target platform in support of it. Signed-off-by: Shell <smokewood@qq.com>
polarvid
force-pushed
the
shell/generic-spinlock
branch
from
a9fc6aa to
da6d9f8
Compare
| ORR X0, X0, #0x38 | ||
| MSR HCR_EL2, X0 | ||
| B 0f | ||
| MRS X0, HCR_EL2 |
BernardXiong
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
Replace the former implementation of flag-based spinlock which is unfair.
Besides, C11 atomic implementation is more readable (it's C anyway),
and maintainable. Cause toolchain can use their builtin optimization and tune for
different micro-architectures. For example armv8.5 introduces a better instruction.
the compiler can help with that when it knows you target platform in support of it).
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up