Skip to content

install_requires incomplete? #51

New issue
New issue
Closed
Closed
install_requires incomplete?#51

Description

@pllim
pllim
opened on Aug 15, 2022

I see that in your CI workflow, you install a few more things than what is declared in your setup.py. Are they really needed? If so, they should be declared as install_requires or as optional dependencies in setup.py. Also see #47

https://github.com/Jammy2211/PyAutoGalaxy/blob/449d5a11c70439010a27d7ceffe20d4c6af13c48/.github/workflows/main.yml#L12-L26

https://github.com/Jammy2211/PyAutoGalaxy/blob/449d5a11c70439010a27d7ceffe20d4c6af13c48/.github/workflows/main.yml#L71-L75

astropy/astropy.github.com#491 (comment)

Activity

  1. pllim commented on Aug 15, 2022

    @pllim
    pllim
    on Aug 15, 2022
    ContributorAuthor

    Ah, also I found this documentation that suggests setup.py declarations are indeed incomplete: https://pyautogalaxy.readthedocs.io/en/latest/installation/overview.html#dependencies and https://pyautogalaxy.readthedocs.io/en/latest/installation/source.html#building-from-source

  2. Jammy2211
    closed this as completedon Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions