Skip to content

Move install_requires from requirements.txt to setup.py #47

Closed

Description

@pllim

Currently install_requires requirements are buried in a text file. Would be easier to discover if it is just done in setup.py . No reason to have file I/O overhead during setup for those entries.

Bonus: Move all that data from setup.py to setup.cfg for easier to read package info.

astropy/astropy.github.com#491 (comment)

Activity

  1. Jammy2211 commented on Nov 28, 2022

    @Jammy2211
    Collaborator

    We are going to adopt this: #67

    Would listing all requirements and optional requirements in the pyproject.toml file satisfy this issue?

  2. pllim commented on Nov 28, 2022

    @pllim
    ContributorAuthor

    Yes, since I posted this, using pyproject.toml instead of setup.cfg is now popular. As long as you don't mind pinning to a much newer version of setuptools, I think that is the way to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions