Move routes to ./routes.js & convert last few definitions to app_route#331
Merged
Conversation
Member
|
Tested on dev +1.... however I need to wait for sizzle to respond since this is a portion of what he told me he was doing... it is however exactly what he explained to me needed to be done along with the controllers. |
Contributor
|
@Zren commented on 28 aug. 2014 01:53 CEST:
Thanks for that link! Looks very clear structured and fully featured. 👍 on merging this. |
Martii
added a commit
that referenced
this pull request
Aug 28, 2014
Move routes to ./routes.js & convert last few definitions to app_route
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Sep 6, 2014
* Sort package.json packages * Use absolute versions for npm packages... closes OpenUserJS#321 * Change README.md to reflect moved/new packages * Fix whitespace `function(` to `function (` from OpenUserJS#331 * Using for express-minify for server side .js and .css minification ... applies to OpenUserJS#330 * Create `./routesStatic.js` and move/create all static routes into it ... applies to OpenUserJS#330 * Remove static copies which closes OpenUserJS#330 Parallel change e.g. no new dependency updates such as *font-awesome* and *bootstrap* Many thanks to @jerone, @Zren, and @cletusc for assistance in team biz for these issues.
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Sep 7, 2014
Applies to OpenUserJS#330 and required by OpenUserJS#255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been checking our the structure of other Express/Mongoose projects and found https://github.com/jedireza/drywall. I like how they structure their app, so I'll be adding a few PRs that reflect some of the smaller things.
app.jsis our main entrypoint. Right now, we have over 100 lines of route definitions. Might as well move it to it's own file.