Skip to content

Always call npm install when preparing project #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosen-vladimirov merged 1 commit into from
Oct 21, 2015
Merged

Always call npm install when preparing project #1087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lib/services/plugins-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,13 +189,11 @@ export class PluginsService implements IPluginsService {

public ensureAllDependenciesAreInstalled(): IFuture<void> {
return (() => {
if(!this.$fs.exists(path.join(this.$projectData.projectDir, constants.NODE_MODULES_FOLDER_NAME)).wait()) {
let command = "npm install ";
if(this.$options.ignoreScripts) {
command += "--ignore-scripts";
}
this.$childProcess.exec(command, { cwd: this.$projectData.projectDir }).wait();
let command = "npm install ";
if(this.$options.ignoreScripts) {
command += "--ignore-scripts";
}
this.$childProcess.exec(command, { cwd: this.$projectData.projectDir }).wait();
}).future<void>()();
}

Expand Down
5 changes: 4 additions & 1 deletion test/npm-support.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,10 @@ describe("Npm support tests", () => {
let scopedName = "@reactivex/rxjs";
let scopedModule = path.join(projectFolder, "node_modules", "@reactivex/rxjs");
let scopedPackageJson = path.join(scopedModule, "package.json");
addDependencies(testInjector, projectFolder, {scopedName: "0.0.0-prealpha.3"}).wait();
let dependencies: any = {};
dependencies[scopedName] = "0.0.0-prealpha.3";
// Do not pass dependencies object as the sinopia cannot work with scoped dependencies. Instead move them manually.
addDependencies(testInjector, projectFolder, {}).wait();
//create module dir, and add a package.json
shelljs.mkdir("-p", scopedModule);
fs.writeFile(scopedPackageJson, JSON.stringify({name: scopedName})).wait();
Expand Down