Always call npm install when preparing project - #1087
Merged
Conversation
Contributor
Author
|
run ci |
rosen-vladimirov
force-pushed
the
vladimirov/always-install-deps
branch
from
October 20, 2015 16:00
d01214b to
c2dac4a
Compare
|
Test FAILed. |
rosen-vladimirov
force-pushed
the
vladimirov/always-install-deps
branch
from
October 20, 2015 16:10
c2dac4a to
d9251ea
Compare
|
Test FAILed. |
Contributor
|
👍 |
Preparing project should always call `npm install` just to make sure all dependencies are installed. Currently we are not calling it when node_modules dir exists. This was due to requirement that when you have node_modules and change something in node_modules/tns-core-modules directory, `npm install` will override your changes. The fact is that this is totally incorrect behavior on our side and also making changes in `node_modules/<package_name>` is forbidden. Anyway, in case you make changes there, calling `npm install` will not override them. Remove the incorrect check and always call `npm install`.
rosen-vladimirov
force-pushed
the
vladimirov/always-install-deps
branch
from
October 21, 2015 17:29
d9251ea to
6e3db2b
Compare
|
Test PASSed. |
rosen-vladimirov
added a commit
that referenced
this pull request
Oct 21, 2015
…deps Always call npm install when preparing project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing project should always call
npm installjust to make sure all dependenciesare installed. Currently we are not calling it when node_modules dir exists.
This was due to requirement that when you have node_modules and change something in
node_modules/tns-core-modules directory,
npm installwill override your changes.The fact is that this is totally incorrect behavior on our side and also making changes
in
node_modules/<package_name>is forbidden. Anyway, in case you make changes there,calling
npm installwill not override them.Remove the incorrect check and always call
npm install.Fix unit test which was passing due to missing npm install before. The problem with it now is that
Will create an object with property "scopedName" instead of the required one
"@reactivex/rxjs".