Repository navigation
Use uppercase cuDLA status names with backward-compatible aliases - #3307
Merged
Merged
Conversation
— codex GPT-6 on behalf of Ralf — Run cybind native generation for CUDA 13.4.2. The generated change gives cuDLA status members uppercase canonical names and retains the previous camel-case names as backward-compatible aliases. Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
— codex GPT-6 on behalf of Ralf — Expect the uppercase canonical status name in CudlaError messages while retaining coverage of the legacy enum alias and checking its identity. Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
the
cuda.bindings
Contributor
Author
|
/ok to test |
rwgk
marked this pull request as ready for review
October 30, 2026 22:44
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Status enum names cuda_bindings_13/cuda/bindings/cudla.pyx, cuda_bindings_13/tests/cudla/test_cudla_bindings.py |
Status adds uppercase names and retains mixed-case names as aliases. The test checks that both names identify the same member and expects ERROR_INVALID_PARAM in the error string. |
Change: Refactor
Merge Risk: 
78ffb
-
No merge-blocking risk is identified for the status-name aliases.
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Contributor
|
mdboom
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
— codex GPT-6 on behalf of Ralf —
Description
cuDLA status enum members now use uppercase canonical names such as
Status.SUCCESSandStatus.ERROR_INVALID_PARAM. Existing camel-case names remain aliases to the same enum members.Regenerate the native bindings for CUDA 13.4.2 and update the error-message regression test:
CudlaErrorformats the canonical member name, so the message is nowERROR_INVALID_PARAM (1). The test continues constructing the error through the legacy alias and explicitly checks alias identity.Validation
pre-commit run --all-filespassed.Checklist