Skip to content

fix(vm-driver): fixes BYOC sandbox creation failing with ext4-fs writ… #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bornav wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −2
Open

fix(vm-driver): fixes BYOC sandbox creation failing with ext4-fs writ… #2150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crates/openshell-driver-vm/scripts/openshell-vm-sandbox-init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,12 @@ setup_overlay_root() {
if [ "${OPENSHELL_VM_INIT_MODE:-sandbox}" = "image-prep" ]; then
prepare_guest_image_rootfs
sync
if mount -o remount,ro /overlay 2>/dev/null; then
:
else
umount /overlay
fi
sync
ts "image-prep complete"
exit 0
fi
Expand All @@ -252,7 +258,7 @@ setup_overlay_root() {

local lower_root="/lower"
if [ -b /dev/vdc ]; then
mount -t ext4 -o ro /dev/vdc /image-cache
mount -t ext4 -o ro,noload /dev/vdc /image-cache
if [ -d /image-cache/image-rootfs ]; then
lower_root="/image-cache/image-rootfs"
ts "using prepared image rootfs lowerdir"
Expand Down
7 changes: 6 additions & 1 deletion crates/openshell-driver-vm/src/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,12 @@ impl VmContext {
self.ctx_id,
image_block_id_c.as_ptr(),
image_disk_c.as_ptr(),
true,
// Attach as writable at the hypervisor level so the
// kernel can replay the ext4 journal if the image-prep
// VM did not unmount cleanly. The guest still mounts
// the filesystem with -o ro, so guest processes cannot
// write to it. See: openshell-vm-sandbox-init.sh
false,
)
},
"krun_add_disk",
Expand Down
Loading