fix(vm-driver): fixes BYOC sandbox creation failing with ext4-fs writ…#2150
Open
bornav wants to merge 1 commit into
Open
fix(vm-driver): fixes BYOC sandbox creation failing with ext4-fs writ…#2150bornav wants to merge 1 commit into
bornav wants to merge 1 commit into
Conversation
…e access unavailable
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
mise run pre-commit fails both on main and with my patch with error: |
Author
|
I have read the DCO document and I hereby sign the DCO. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix BYOC sandbox creation failing with "EXT4-fs (vdc): write access unavailable, cannot proceed" under the VM driver by cleanly unmounting the overlay filesystem before the image-prep VM exits, preventing the ext4 journal from being left in a dirty state. Adds noload to the image-cache mount and attaches the disk as hypervisor-writable as belt-and-suspenders so a dirty journal never blocks the mount.
Related Issue
Closes #2149
Changes
changing how VM driver creates container
Testing
mise run pre-commitpasses | check commentUnit tests added/updated
E2E tests added/updated (if applicable)
manually tested before and after patch if it fixes the issue
Checklist