fix(release): bump electron-builder to 26.16.1 for macOS keychain fix - #87
Merged
Merged
Conversation
macOS release builds started failing on Sep 8 with "SecKeychainUnlock: The user name or passphrase you entered is not correct" during set-key-partition-list. electron-builder 26.15.6 passes the .p12 import password there instead of the temporary keychain's own password. Older runner images tolerated that; the macos-26 image rolled out between Sep 3 and Sep 8 (macOS 25.6.0) does not. 26.16.1 carries the v26 backport of electron-userland/electron-builder PR 10101 (issue 10066) and passes the keychain password. Lockfile refreshed; no other version pins referenced 26.15.6. Made with Claude Fable 5.1 in Claude Code.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
macOS release builds have failed since Sep 8 during code signing:
electron-builder 26.15.6 passes the
.p12import password toset-key-partition-listinstead of the temporary keychain's own password. Older runner images tolerated that. Themacos-latestimage moved from 20260728 (macOS 25.5.0) to 20260831 (macOS 25.6.0) between the last good release on Sep 3 and the first failure on Sep 8, with identical build code and the same electron-builder pin. Tracked upstream as electron-userland/electron-builder#10066, fixed in pingdotgg#10101 and backported to the v26 line in #10172.Fix
Pin
electron-builderto 26.16.1 and refresh the lockfile. app-builder-lib, dmg-builder, and electron-builder-squirrel-windows all move to 26.16.1. I verified the installedapp-builder-lib/out/codeSign/macCodeSign.jsnow passeskeychainPasswordtoset-key-partition-list. No pnpm override or patch references the old version.Verification
scripts/sign-macos.test.tsandscripts/build-desktop-artifact.test.tspass (58 tests). The real proof is the Release run triggered by merging this.Made with Claude Fable 5.1 in Claude Code.