Skip to content

fix(decision-pack): include rejected recommendation feedback #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jun 19, 2026
Merged

fix(decision-pack): include rejected recommendation feedback #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/services/decision-pack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ export type RepoRecommendationOutcomeFeedback = {
positive: number;
negative: number;
merged: number;
rejected: number;
closed: number;
stale: number;
ignored: number;
Expand Down Expand Up @@ -1027,6 +1028,7 @@ function summarizeRecommendationOutcomeFeedback(feedback: AgentRecommendationOut
positive: feedback.positive,
negative: feedback.negative,
merged: feedback.merged,
rejected: feedback.rejected,
closed: feedback.closed,
stale: feedback.stale,
ignored: feedback.ignored,
Expand All @@ -1043,7 +1045,7 @@ function recommendationFeedbackWhyThisHelps(feedback: RepoRecommendationOutcomeF

function recommendationFeedbackRiskReasons(feedback: RepoRecommendationOutcomeFeedback | undefined): string[] {
if (!feedback || feedback.negative === 0) return [];
return [`Private recommendation feedback has ${feedback.negative} unresolved or negative contributor-lane outcome(s) for this repo (${feedback.closed} closed, ${feedback.stale} stale, ${feedback.ignored} ignored).`];
return [`Private recommendation feedback has ${feedback.negative} unresolved or negative contributor-lane outcome(s) for this repo (${feedback.rejected} rejected, ${feedback.closed} closed, ${feedback.stale} stale, ${feedback.ignored} ignored).`];
}

function recommendationOutcomePriorityAdjustment(feedback: RepoRecommendationOutcomeFeedback | undefined): number {
Expand Down
10 changes: 6 additions & 4 deletions test/unit/decision-pack.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ describe("decision-pack service", () => {
},
});

expect(decision.recommendationOutcomeFeedback).toMatchObject({ signal: "positive", positive: 3, negative: 1, maintainerLaneTotal: 2 });
expect(decision.recommendationOutcomeFeedback).toMatchObject({ signal: "positive", positive: 3, rejected: 0, negative: 1, maintainerLaneTotal: 2 });
expect(decision.priorityScore).toBeGreaterThan(baseline.priorityScore);
expect(decision.whyThisHelps.some((line) => line.includes("Private recommendation feedback"))).toBe(true);
expect(decision.riskReasons.some((line) => line.includes("Private recommendation feedback"))).toBe(true);
Expand All @@ -244,11 +244,11 @@ describe("decision-pack service", () => {
repoFullName: "owner/direct",
total: 6,
accepted: 0,
rejected: 0,
rejected: 2,
ignored: 2,
stale: 2,
stale: 1,
merged: 0,
closed: 2,
closed: 1,
improved: 0,
positive: 0,
negative: 6,
Expand Down Expand Up @@ -280,7 +280,9 @@ describe("decision-pack service", () => {
});

expect(negative.priorityScore).toBeLessThan(baseline.priorityScore);
expect(negative.recommendationOutcomeFeedback).toMatchObject({ negative: 6, rejected: 2, closed: 1, stale: 1, ignored: 2 });
expect(negative.riskReasons.join(" ")).toMatch(/6 unresolved or negative/);
expect(negative.riskReasons.join(" ")).toContain("2 rejected, 1 closed, 1 stale, 2 ignored");
expect(negative.whyThisHelps.some((line) => line.includes("Private recommendation feedback"))).toBe(false);
expect(mixed.priorityScore).toBeLessThan(baseline.priorityScore);
expect(mixed.riskReasons.join(" ")).toMatch(/2 unresolved or negative/);
Expand Down
Loading