fix(decision-pack): include rejected recommendation feedback

[JSONbored]

Motivation

• The repo-level outcome summaries began counting a new rejected outcome but the decision-pack projection omitted it, causing negative totals to list counts without the rejected breakdown and producing misleading private guidance.

Description

• Add a rejected: number field to the RepoRecommendationOutcomeFeedback projection so consumers receive the rejected count.
• Thread feedback.rejected through summarizeRecommendationOutcomeFeedback so repo summaries preserve the rejected value.
• Include rejected in the private negative feedback explanation text so the risk message lists rejected along with closed/stale/ignored counts.
• Update unit tests in test/unit/decision-pack.test.ts to assert the rejected count is preserved and appears in the risk explanation.

Testing

• Ran git diff --check to verify no whitespace/errors were introduced and it succeeded.
• Ran npx vitest run test/unit/decision-pack.test.ts test/unit/recommendation-outcomes.test.ts --reporter=dot and all tests passed (Test Files 2 passed, Tests 56 passed).

---

Codex Task

[ghost]

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal	Result	Evidence	Action
Gate result	⚠️ Skipped	#914 is no longer open.	No action.

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.71%. Comparing base (5d9d73a) to head (75049cd).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #914   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files         108      108           
  Lines       14641    14641           
  Branches     5298     5298           
=======================================
  Hits        14160    14160           
  Misses        102      102           
  Partials      379      379           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ghost]

gittensory · advisory review

Reviewed 2 changed file(s) — two independent AI reviewers.

Changed files: src/services/decision-pack.ts, test/unit/decision-pack.test.ts

Suggested action: ✅ Safe to merge — both reviewers found no blocking issues.

Reviewer A · gpt-oss-120b — recommends ✅ merge
The PR extends the recommendation outcome feedback model with a new rejected count, updates summary and risk messaging, and adjusts unit tests accordingly. The change is small, type‑safe, and does not affect public sanitization or security.

Suggestions

• Verify that any other places constructing RepoRecommendationOutcomeFeedback now provide a rejected value (or default it to 0) to satisfy the updated type definition.
• Consider adding a test case where rejected > 0 influences the priority adjustment, if that logic is intended to change.

Worth double-checking

• Potential TypeScript compile errors in modules that still create RepoRecommendationOutcomeFeedback without the new rejected field.
• If rejected should affect priority scoring, the current logic may miss it.

Reviewer B · mistral-small-3.1-24b-instruct — recommends ✅ merge
This PR adds a 'rejected' field to the recommendation feedback structure and updates related functions and tests. The change is small, focused, and well-tested.

Suggestions

• Consider adding a comment explaining why the 'rejected' field is necessary and how it improves the decision-pack logic.

Worth double-checking

• Ensure that the addition of the 'rejected' field does not introduce any regressions in the decision-pack logic.
• Verify that all relevant tests cover the new 'rejected' field and its impact on decision-making.