Skip to content

test(review): seed the live pull_requests ledger for the submission-cadence tests #9096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RealDiligent wants to merge 1 commit into from
Closed

test(review): seed the live pull_requests ledger for the submission-cadence tests #9096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/unit/reputation-wiring.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,12 +279,21 @@ describe("shouldSkipAiForReputation (helper)", () => {

describe("submission-cadence signal (#4514)", () => {
async function seedReviewTarget(env: Env, args: { number: number; submitter: string; createdAt: string }) {
// Merged/approved review_targets keep the QUALITY signal neutral/trusted, so only cadence can trip these.
await env.DB.prepare(
`INSERT INTO review_targets (id, project, kind, repo, number, submitter, status, decision_json, terminal_at, created_at)
VALUES (?, 'acme/widgets', 'pull_request', 'acme/widgets', ?, ?, 'merged', ?, ?, ?)`,
)
.bind(`acme/widgets:pull_request:acme/widgets#${args.number}`, args.number, args.submitter, JSON.stringify({ reasonCode: "dual_review_approved" }), args.createdAt, args.createdAt)
.run();
// #9041 moved getSubmitterCadence off the cutover-frozen review_targets to the LIVE pull_requests ledger,
// so the submission-cadence signal is sourced from here now -- seed it too or the query reads 0 samples.
await env.DB.prepare(
`INSERT INTO pull_requests (id, repo_full_name, number, title, state, author_login, created_at)
VALUES (?, 'acme/widgets', ?, 'PR', 'open', ?, ?)`,
)
.bind(`acme/widgets#${args.number}`, args.number, args.submitter, args.createdAt)
.run();
}

it("FLAG-ON: true for a machine-paced submitter even though every submission itself looks fine (quality-neutral)", async () => {
Expand Down